RE: [PATCH 01/11] dt-bindings: Add vendor prefix for Silicon Linux.

Chris Paterson
2019-01-17T12:24:11Z

Hello Andreas, Simon,

Thank you for your reviews.

> From: Simon Horman <horms@verge.net.au>
> Sent: 17 January 2019 12:19
>
> On Thu, Jan 17, 2019 at 12:17:56PM +0100, Andreas Färber wrote:
> > Hi Fabrizio,
> >
> > Am 16.01.19 um 19:37 schrieb Fabrizio Castro:
> > > From: Biju Das <biju.das@bp.renesas.com>
> > >
> > > Add Silicon Linux to the list of devicetree vendor prefixes.
> > >
> > > Website: http://www.si-linux.co.jp
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > ---
> > > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > > index 4b1a2a8..02a7037 100644
> > > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > > @@ -344,6 +344,7 @@ sgx SGX Sensortech
> > > sharp Sharp Corporation
> > > shimafuji Shimafuji Electric, Inc.
> > > si-en Si-En Technology Ltd.
> > > +si-linux Silicon Linux Corporation
> >
> > With the website being Japanese only, I haven't been able to confirm the
> > spelling of the company name. Looks sensible though.
>
> According to the company web site
> (http://si-
> linux.co.jp/index.php?%E4%BC%9A%E7%A4%BE%E6%A1%88%E5%86%85)
> the company name is.
>
> Japanese: シリコンリナックス株式会社
> English: Silicon Linux Corporation

I can also confirm that this is what we've been told by Si-Linux themselves 😊

Kind regards, Chris

>
> And in my opinion these are equivalent (although other translations of
> the corporation bit are possible).
>
> > Due to "en" coming before "five" I've double-checked that elsewhere we
> > do order dashes before letters, so placement in file and tab-indentation
> > is fine, too.
> >
> > > sifive SiFive, Inc.
> > > sigma Sigma Designs, Inc.
> > > sii Seiko Instruments, Inc.
> >
> > Personally I would drop the full stop at the end of the subject, but anyway:
> >
> > Reviewed-by: Andreas Färber <afaerber@suse.de>
> >
> > Thanks,
> > Andreas
> >
> > P.S. Please double-check how this excessive CC list came to life!
> >
> > --
> > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> > GF: Felix Imendörffer, Jane Smithard, Graham Norton
> > HRB 21284 (AG Nürnberg)
> >