Re: [PATCH 4/4] drm/panel: Add OSD101T2587-53TS driver

Peter Ujfalusi
2019-02-20T12:06:25Z

Hi Sam,

On 20/02/2019 13.52, Sam Ravnborg wrote:
> Hi Peter.
>
> On Wed, Feb 20, 2019 at 12:39:11PM +0200, Peter Ujfalusi wrote:
>> Hi Sam,
>>
>> On 15/02/2019 20.07, Sam Ravnborg wrote:
>>>> +#include <linux/backlight.h>
>>>> +#include <linux/module.h>
>>>> +#include <linux/of.h>
>>>> +#include <linux/regulator/consumer.h>
>>>> +
>>>> +#include <drm/drmP.h>
>>> Please do not use drmP.h in new drivers - we try to get rid of this file.
>>
>> ...
>>
>>>> +static int osd101t2587_panel_get_modes(struct drm_panel *panel)
>>>> +{
>>>> + struct osd101t2587_panel *osd101t2587 = to_osd101t2587_panel(panel);
>>>> + struct drm_display_mode *mode;
>>>> +
>>>> + mode = drm_mode_duplicate(panel->drm, osd101t2587->default_mode);
>>>> + if (!mode) {
>>>> + dev_err(panel->drm->dev, "failed to add mode %ux%ux@%u\n",
>>
>> drm/drmP.h is needed for this dev_err.
> drmP.h is only a set of include files and forwards today.
> So you need to figure out what to replace it with.
>
> Often removing drmP.h requires you to add more than one extra include file.

Replacing it with
#include <drm/drm_device.h>

works perfectly.

Thanks,
- Péter