From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Sultan Alsawaf <sultan@kerneltoast.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] random: fix inconsistent spinlock usage
Date: Sat, 16 Feb 2019 12:59:53 -0500 [thread overview]
Message-ID: <20190216175953.GD23000@mit.edu> (raw)
In-Reply-To: <CAFArEyWsuvEMFQ-CpTeawBbDY1egDzXf1HaOyd9z-uKcbSCq=Q@mail.gmail.com>
On Fri, Feb 15, 2019 at 02:03:06PM -0800, Sultan Alsawaf wrote:
> All users of the struct entropy_store spinlock use the irqsave spinlock variant.
> Spinlock users of the same lock should use be consistent in their use of a
> certain spinlock primitive, which makes add_interrupt_randomness()'s spinlock
> usage incorrect.
>
> Fix the inconsistency by converting add_interrupt_randomness()'s spinlocks to
> use the irqsave primitive.
>
> Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
This isn't a problem; interrupts are off by definition when
add_interrupt_randomness() is called so there's no point using the
irqsave version.
Also, please note that your patches are whitespace damaged, so they
can't be applied directly. You may want to look into how you are
sending your patches.
Regards,
- Ted
prev parent reply other threads:[~2019-02-16 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 22:03 [PATCH] random: fix inconsistent spinlock usage Sultan Alsawaf
2019-02-16 17:59 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190216175953.GD23000@mit.edu \
--to=tytso@mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=sultan@kerneltoast.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox