From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: thesven73@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] Input: synaptics_i2c - remove redundant spinlock
Date: Sat, 16 Feb 2019 21:29:59 -0800 [thread overview]
Message-ID: <20190217052959.GB107793@dtor-ws> (raw)
In-Reply-To: <20190212013442.26030-1-TheSven73@gmail.com>
Hi Sven,
On Mon, Feb 11, 2019 at 08:34:42PM -0500, thesven73@gmail.com wrote:
> @@ -372,13 +371,7 @@ static bool synaptics_i2c_get_input(struct synaptics_i2c *touch)
> static void synaptics_i2c_reschedule_work(struct synaptics_i2c *touch,
> unsigned long delay)
> {
> - unsigned long flags;
> -
> - spin_lock_irqsave(&touch->lock, flags);
> -
> mod_delayed_work(system_wq, &touch->dwork, delay);
> -
> - spin_unlock_irqrestore(&touch->lock, flags);
> }
This makes synaptics_i2c_reschedule_work() a useless wrapper for
mod_delayed_work(). Can we get rid of it?
Thanks.
--
Dmitry
prev parent reply other threads:[~2019-02-17 5:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 1:34 [PATCH] Input: synaptics_i2c - remove redundant spinlock thesven73
2019-02-17 5:29 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190217052959.GB107793@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thesven73@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox