* [PATCH] block: Replace function name in string with __func__
@ 2019-02-17 15:21 iamkeyur96
2019-02-28 21:09 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: iamkeyur96 @ 2019-02-17 15:21 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, Keyur Patel
From: Keyur Patel <iamkeyur96@gmail.com>
Replace hard coded function name register_blkdev with __func__, to
improve robustness and to conform to the Linux kernel coding
style. Issue found using checkpatch.
Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
---
block/genhd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/genhd.c b/block/genhd.c
index 1dd8fd6613b8..33ab7150fbe4 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -365,8 +365,8 @@ int register_blkdev(unsigned int major, const char *name)
}
if (index == 0) {
- printk("register_blkdev: failed to get major for %s\n",
- name);
+ printk("%s: failed to get major for %s\n",
+ __func__, name);
ret = -EBUSY;
goto out;
}
@@ -375,8 +375,8 @@ int register_blkdev(unsigned int major, const char *name)
}
if (major >= BLKDEV_MAJOR_MAX) {
- pr_err("register_blkdev: major requested (%u) is greater than the maximum (%u) for %s\n",
- major, BLKDEV_MAJOR_MAX-1, name);
+ pr_err("%s: major requested (%u) is greater than the maximum (%u) for %s\n",
+ __func__, major, BLKDEV_MAJOR_MAX-1, name);
ret = -EINVAL;
goto out;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: Replace function name in string with __func__
2019-02-17 15:21 [PATCH] block: Replace function name in string with __func__ iamkeyur96
@ 2019-02-28 21:09 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-02-28 21:09 UTC (permalink / raw)
To: iamkeyur96; +Cc: linux-block, linux-kernel
On 2/17/19 8:21 AM, iamkeyur96@gmail.com wrote:
> From: Keyur Patel <iamkeyur96@gmail.com>
>
> Replace hard coded function name register_blkdev with __func__, to
> improve robustness and to conform to the Linux kernel coding
> style. Issue found using checkpatch.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-28 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-17 15:21 [PATCH] block: Replace function name in string with __func__ iamkeyur96
2019-02-28 21:09 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox