From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA28C43381 for ; Mon, 18 Feb 2019 08:51:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 033C52089F for ; Mon, 18 Feb 2019 08:51:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S2HAmE+G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729561AbfBRIvT (ORCPT ); Mon, 18 Feb 2019 03:51:19 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:45563 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727951AbfBRIvS (ORCPT ); Mon, 18 Feb 2019 03:51:18 -0500 Received: by mail-wr1-f67.google.com with SMTP id w17so17321901wrn.12; Mon, 18 Feb 2019 00:51:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mamwhN/sM3mQrY82dAd8MPDO7H3lOgfK1aKDxaHtUpg=; b=S2HAmE+GS4oTZQ1lhburgbsWfgxkUIHHFXEL/V+LQry3pM411kSmNPaUPsmarYi4dF rJexYF+vqw1XOEUHWbDYIkrN5QFKHzvn4D4C39bn8l9m6DYjTmwT9M+cotAofNtUGVOX /j6MJy8UskoL5oYhGbmSgrLD/DbEltBw1y2eHTjgw24EsiO0Pv9zypfqC2KZJAco8CwL 77oGNd7Pu4tWlMKbBVYQhcguFjEFvYkkdP0mdB9Dio8kwp4xmW4fzqElHdyxs6ddPR8V HTu1z4NsZWwtNV7SMRktnNl/7uAdexvvTM8o0eN/soY+ZnkY6vlTTJ+Uc+/G6KEOK9PA YNzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mamwhN/sM3mQrY82dAd8MPDO7H3lOgfK1aKDxaHtUpg=; b=K6i5BklsrfryWCA2+JBessOxJgxxWD/ImgL3g6gZfZp7qGqaYBShR5uCzRjF1gDcZG 1RUiVB8fiHZFTeeRSNmO8TXWP7gPGqqzvTOWQ3IZzjSDmKjrUnNabMBuRGcB8LlXA/2x KJIuRhXOlW/b70k53sfS2luBMr0X+I14wT4Exie9n6xfajLyIxikYAY3FJCex3jLGHty uwh5FObupicn5R/FyOxqTA4hjOYS+1PxQcfpMD+lQI3d3A+iZJYhrhBtIvhB6+6o+mVr QK8vN6WUfMC5WfCe7JLyKizuXrkzcMM9tgXTwDU2kU6Q8w8eh1c3vDBlEkBnKxpWeuP8 VXag== X-Gm-Message-State: AHQUAuYqp77VcFSqO9ZCY8c1yEE5uHLHlHU44BF0jAeEkyIlTsP+ugWm 3y93O4hIox1t0nk9+DG6S4c= X-Google-Smtp-Source: AHgI3Ib7MopIQiaqFCGcEdaR26sE3L0rZcj0k03vZ5T4WaSNicX2HYkC2z5GlDR3DqHIB2Ci8LCWhg== X-Received: by 2002:adf:ed11:: with SMTP id a17mr15978800wro.283.1550479876227; Mon, 18 Feb 2019 00:51:16 -0800 (PST) Received: from localhost (pD9E51D2D.dip0.t-ipconnect.de. [217.229.29.45]) by smtp.gmail.com with ESMTPSA id n3sm14351671wrs.10.2019.02.18.00.51.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Feb 2019 00:51:15 -0800 (PST) Date: Mon, 18 Feb 2019 09:51:14 +0100 From: Thierry Reding To: Russell King Cc: Dmitry Osipenko , Jonathan Hunter , Robert Yang , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/8] Support Trusted Foundations firmware on Tegra30 Message-ID: <20190218085114.GC19363@ulmo> References: <20190218001726.16785-1-digetx@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+xNpyl7Qekk2NvDX" Content-Disposition: inline In-Reply-To: <20190218001726.16785-1-digetx@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+xNpyl7Qekk2NvDX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 18, 2019 at 03:17:18AM +0300, Dmitry Osipenko wrote: > Hello, >=20 > This patchset adds support for the Trusted Foundations firmware on > NVIDIA Tegra30. Pretty much all of Tegra30 consumer devices have that > firmware and upstream kernel can't boot on those devices without the > firmware support. >=20 > Changelog: >=20 > v4: - Fixed Thumb2-kernel hanging on Tegra20, turned out it was not a > good idea to switch CPU into Thumb2 mode right after jumping in= to > the reset handler. >=20 > - Moved LP2-mode-set firmware call invocation to a later stage to > better replicate what downstream kernel does. This change was > suggested by Robert Yang and fixes system hang on Ouya game > console. >=20 > - Added references to the original work made by Micha=C5=82 Miros= =C5=82aw > into commit messages of the relevant patches. >=20 > v3: - Implemented suspend-resume support. >=20 > - Reworked arm/firmware/trusted_foundations.c a tad. Now cache > is getting properly initialized, cache enabling / disabling is > supported. >=20 > v2: > - The "Don't apply CPU erratas in insecure mode" patch got some > cleanup, in particular resolved the messiness in > __tegra_cpu_reset_handler_data. >=20 > - Added a comment to tf_cache_write_sec(), justifying the warning > message. >=20 > Dmitry Osipenko (8): > ARM: trusted_foundations: Implement L2 cache initialization callback > ARM: trusted_foundations: Make prepare_idle call to take mode argument > ARM: trusted_foundations: Provide information about whether firmware > is registered > ARM: tegra: Set up L2 cache using Trusted Foundations firmware > ARM: tegra: Don't apply CPU erratas in insecure mode > ARM: tegra: Always boot CPU in ARM-mode > ARM: tegra: Support L2 cache maintenance done via firmware > ARM: tegra: Add firmware calls required for suspend-resume >=20 > arch/arm/firmware/trusted_foundations.c | 80 +++++++++++++++++++++- > arch/arm/include/asm/firmware.h | 2 +- > arch/arm/include/asm/trusted_foundations.h | 13 ++++ > arch/arm/mach-tegra/cpuidle-tegra114.c | 3 +- > arch/arm/mach-tegra/pm.c | 50 ++++++++++++++ > arch/arm/mach-tegra/reset-handler.S | 52 ++++++++++---- > arch/arm/mach-tegra/reset.c | 3 + > arch/arm/mach-tegra/reset.h | 9 ++- > arch/arm/mach-tegra/sleep-tegra20.S | 4 ++ > arch/arm/mach-tegra/sleep.S | 11 +-- > arch/arm/mach-tegra/tegra.c | 10 +++ > 11 files changed, 214 insertions(+), 23 deletions(-) Hi Russell, I'm not sure if this is something that you have a vested interest in. It looks like Tegra is the only platform that uses this, and usage is limited to two generations (Tegra30 and Tegra114). Do you mind if I pick this up into the Tegra tree and send this as part of the pull requests for v5.2? Actually, Trusted Foundations is the only firmware implementation left in arch/arm/firmware, so how about we move this file over to drivers/firmware (perhaps even the tegra subdirectory given that nobody else seems to be using it) and get rid of arch/arm/firmware? I can prepare a patch that does that on top of this series, just let me know how you want to handle this. Thanks, Thierry --+xNpyl7Qekk2NvDX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlxqcgIACgkQ3SOs138+ s6GX/w//W+g1W1nxSBXL3svlE2qwDtpUVy7dQayozIareXJOzKQtUWv024Df4KKN nbP841bAkpdJ60BQTAsmBg22uHgSU0EMm+lEUoqw1PlUXxTip4z3EEvqCShA+489 bDRwXYFFW0vC9b4ModO6o10DMeqcbpUn8kHRXtKXcK9W/H6XHbyDxNArwu9iov7t AFT+1g+tNctC9BTHmuk982IPpP677Kf+DWoTnfaSROylxGL4vVLi6pgc8LSDPG/N mQssOAFbZygKdFk6Ee4cxfKxjIy3D91AG7jk2NYeD6+8N4CtsaDQVgL60KOjjQdJ oruj/k7vD72ol4SvX+PIJouV6orgauRGQOAVBQuLta1GoXF5XXF+n0U7/VhhPW8y A6knDLy6RqvWtW1sD/mTOTH9TSuS1ru/DFBiOZXsnA2qAxiYt6vw0K22wwn30rFW 9LxqS29GRhu0Xh4UCV567pBMpOpa0qIpJ175OWTu8Bm9ai+ac9UYpPINfamaTLIp j9grXhklN4mJ062zuTPV1SO37zcRhzfeMp+Ci1b52CZdnUl0gkFYzjdvWMSyu6PI fN/lrKI4oEEPB4HuwYX0nsXbB96pFAEks2da6tgG2FTMN8uyUGZaZv1xuHqqJkG/ dWu+JEuOmD8JjPddH2fPZ6/JhpZxMUmhFhdQw+cADQTB4v50v7g= =FU2G -----END PGP SIGNATURE----- --+xNpyl7Qekk2NvDX--