From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH 1/3] perf header: Fix wrong node write in NUMA_TOPOLOGY feature
Date: Mon, 18 Feb 2019 12:39:25 +0100 [thread overview]
Message-ID: <20190218113927.30841-2-jolsa@kernel.org> (raw)
In-Reply-To: <20190218113927.30841-1-jolsa@kernel.org>
We are currently passing the node index instead of the
real node number.
Fixes: fbe96f29ce4b ("perf tools: Make perf.data more self-descriptive (v8)"
Link: http://lkml.kernel.org/n/tip-rbtlsr9ts23c89rki7d4s5sm@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 61ce197c5362..c66f26ec557a 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -879,7 +879,7 @@ static int write_numa_topology(struct feat_fd *ff,
if (ret < 0)
break;
- ret = write_topo_node(ff, i);
+ ret = write_topo_node(ff, j);
if (ret < 0)
break;
}
--
2.17.2
next prev parent reply other threads:[~2019-02-18 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 11:39 [PATCHv2 0/3] perf tools: Assorted fixes Jiri Olsa
2019-02-18 11:39 ` Jiri Olsa [this message]
2019-02-18 11:39 ` [PATCH 2/3] perf tools: Add cpu_topology object Jiri Olsa
2019-02-18 11:39 ` [PATCH 3/3] perf tools: Add numa_topology object Jiri Olsa
2019-02-18 14:08 ` Namhyung Kim
2019-02-18 14:20 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218113927.30841-2-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox