From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "chenzefeng (A)" <chenzefeng2@huawei.com>
Cc: "hjl.tools@gmail.com" <hjl.tools@gmail.com>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"sjenning@redhat.com" <sjenning@redhat.com>,
"jikos@kernel.org" <jikos@kernel.org>,
"vojtech@suse.com" <vojtech@suse.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chengjian (D)" <cj.chengjian@huawei.com>
Subject: Re: [PATCH] x86: livepatch: Treat R_X86_64_PLT32 as R_X86_64_PC32
Date: Mon, 18 Feb 2019 12:47:49 +0100 [thread overview]
Message-ID: <20190218114749.GA602@kroah.com> (raw)
In-Reply-To: <79A62BFA453EFB42B7A4E40AD8F3A2264F2A872D@DGGEMA503-MBX.china.huawei.com>
On Fri, Feb 15, 2019 at 02:01:31AM +0000, chenzefeng (A) wrote:
> On x86-64, for 32-bit PC-relacive branches, we can generate PLT32 relocation, instead of PC32 relocation. and R_X86_64_PLT32 can be treated the same as R_X86_64_PC32 since linux kernel doesn't use PLT.
>
> In linux 4.4 commit b21ebf2fb4cd ("x86: Treat R_X86_64_PLT32 as R_X86_64_PC32") been fixed for the module loading, but not fixed for livepatch relocation, which will fail to load livepatch with the error message as follow:
> relocation failed for symbol <symbol name> at <symbol address>
>
> Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
> ---
> arch/x86/kernel/livepatch.c | 1 +
> 1 file changed, 1 insertion(+)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2019-02-18 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 2:01 [PATCH] x86: livepatch: Treat R_X86_64_PLT32 as R_X86_64_PC32 chenzefeng (A)
2019-02-15 7:28 ` Jiri Kosina
2019-02-15 8:17 ` 答复: " chenzefeng (A)
2019-02-15 9:05 ` Petr Mladek
2019-02-18 5:29 ` chengjian (D)
2019-02-18 9:22 ` Petr Mladek
2019-02-18 11:47 ` gregkh [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-19 8:16 chenzefeng (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218114749.GA602@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chenzefeng2@huawei.com \
--cc=cj.chengjian@huawei.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sjenning@redhat.com \
--cc=tglx@linutronix.de \
--cc=vojtech@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox