From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F175BC4151A for ; Mon, 18 Feb 2019 14:37:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1D9A21917 for ; Mon, 18 Feb 2019 14:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550500638; bh=EuMrBqlc1gM1YyNylSGlW0wc7sPTZcM4FYqwGL4x4+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AfwYNjdl8zDpEBHbowCsTVWw6+AhzruwcnGfZN1w+iKUyVQ6lSXlXi2WAqnDIPKBL 5M1XGB1c8xQEC7iRrSwM+yqWkX1sUsgm9sLmFev95LXkUOOazwatXiRYzHuGAXZOyG 1Q2IK7KmPKOeexKEAGgHX2ZlIjETXZ49XwSIyZTQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389661AbfBROg4 (ORCPT ); Mon, 18 Feb 2019 09:36:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:35682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731979AbfBRNzg (ORCPT ); Mon, 18 Feb 2019 08:55:36 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5381920842; Mon, 18 Feb 2019 13:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550498135; bh=EuMrBqlc1gM1YyNylSGlW0wc7sPTZcM4FYqwGL4x4+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OuD8+0QSkiLNyewKvNf3zEJDmbq8QQBca//Qxr09fp1WyC5wRDrK/cKFyOw0oWYFt GtINkvYtY+wIbXnkJxxIynUC+WbI+lKGwNP8oSw/nE1eU328+An2dNdAmBc4tjkUkZ v1cUPhV5t8VqkSFTJ1IrtW9CFDYrgWv4wVsZh1q0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jamie Lentin , Guenter Roeck , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Julien DAscenzio , Linus Walleij , Sasha Levin Subject: [PATCH 4.14 35/62] ARM: dts: kirkwood: Fix polarity of GPIO fan lines Date: Mon, 18 Feb 2019 14:43:41 +0100 Message-Id: <20190218133508.953063650@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190218133505.801423074@linuxfoundation.org> References: <20190218133505.801423074@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit b5f034845e70916fd33e172fad5ad530a29c10ab ] These two lines are active high, not active low. The bug was found when we changed the kernel to respect the polarity defined in the device tree. Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan") Cc: Jamie Lentin Cc: Guenter Roeck Cc: Jason Cooper Cc: Andrew Lunn Cc: Gregory Clement Cc: Sebastian Hesselbarth Cc: Julien D'Ascenzio Reviewed-by: Andrew Lunn Tested-by: Jamie Lentin Reported-by: Julien D'Ascenzio Tested-by: Julien D'Ascenzio Signed-off-by: Linus Walleij Signed-off-by: Gregory CLEMENT Signed-off-by: Sasha Levin --- arch/arm/boot/dts/kirkwood-dnskw.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/kirkwood-dnskw.dtsi b/arch/arm/boot/dts/kirkwood-dnskw.dtsi index cbaf06f2f78e..eb917462b219 100644 --- a/arch/arm/boot/dts/kirkwood-dnskw.dtsi +++ b/arch/arm/boot/dts/kirkwood-dnskw.dtsi @@ -36,8 +36,8 @@ compatible = "gpio-fan"; pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>; pinctrl-names = "default"; - gpios = <&gpio1 14 GPIO_ACTIVE_LOW - &gpio1 13 GPIO_ACTIVE_LOW>; + gpios = <&gpio1 14 GPIO_ACTIVE_HIGH + &gpio1 13 GPIO_ACTIVE_HIGH>; gpio-fan,speed-map = <0 0 3000 1 6000 2>; -- 2.19.1