From: Lucas Oshiro <lucasseikioshiro@gmail.com>
To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-usp@googlegroups.com,
Anderson Reis <andersonreisrosa@gmail.com>
Subject: [PATCH 2/5] iio:potentiostat:lmp91000: insert braces around if arms
Date: Mon, 18 Feb 2019 14:22:33 -0300 [thread overview]
Message-ID: <20190218172236.7781-3-lucasseikioshiro@gmail.com> (raw)
In-Reply-To: <20190218172236.7781-1-lucasseikioshiro@gmail.com>
Insert braces around all arms of if statement starting on line 214,
and solve these checkpath.el CHECKs:
- lmp91000.c:214: CHECK: braces {} should be used on all arms of this statement
- lmp91000.c:216: CHECK: Unbalanced braces around else statement
Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
Signed-off-by: Anderson Reis <andersonreisrosa@gmail.com>
---
drivers/iio/potentiostat/lmp91000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c
index 03d277621861..ca31be510940 100644
--- a/drivers/iio/potentiostat/lmp91000.c
+++ b/drivers/iio/potentiostat/lmp91000.c
@@ -211,9 +211,9 @@ static int lmp91000_read_config(struct lmp91000_data *data)
ret = of_property_read_u32(np, "ti,tia-gain-ohm", &val);
if (ret) {
- if (of_property_read_bool(np, "ti,external-tia-resistor"))
+ if (of_property_read_bool(np, "ti,external-tia-resistor")) {
val = 0;
- else {
+ } else {
dev_err(dev, "no ti,tia-gain-ohm defined");
return ret;
}
--
2.20.1
next prev parent reply other threads:[~2019-02-18 17:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 17:22 [PATCH 0/5] iio:potentiostat:lmp91000: Adjust codestyle, and minor cleanup changes Lucas Oshiro
2019-02-18 17:22 ` [PATCH 1/5] iio:potentiostat:lmp91000: remove unnecessary parentheses Lucas Oshiro
2019-02-18 17:22 ` Lucas Oshiro [this message]
2019-02-18 17:22 ` [PATCH 3/5] iio:potentiostat:lmp91000: reduce line width and remove blank line Lucas Oshiro
2019-02-18 17:22 ` [PATCH 4/5] iio:potentiostat:lmp91000: invert if statement Lucas Oshiro
2019-02-20 9:52 ` Jonathan Cameron
2019-02-18 17:22 ` [PATCH 5/5] iio:potentiostat:lmp91000: add '\n' on dev_err Lucas Oshiro
2019-02-18 21:01 ` Joe Perches
2019-02-20 9:49 ` Jonathan Cameron
2019-02-20 22:22 ` Joe Perches
2019-02-26 20:15 ` Lucas Oshiro
2019-03-03 16:49 ` Jonathan Cameron
2019-02-20 9:41 ` [PATCH 0/5] iio:potentiostat:lmp91000: Adjust codestyle, and minor cleanup changes Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218172236.7781-3-lucasseikioshiro@gmail.com \
--to=lucasseikioshiro@gmail.com \
--cc=andersonreisrosa@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).