Re: [PATCH v2 4/9] mtd: rawnand: jz4780: Add support for the JZ4740

Paul Cercueil
2019-02-03T14:11:08Z

Le dim. 3 févr. 2019 à 11:08, Boris Brezillon <bbrezillon@kernel.org>
a écrit :
> On Sun, 03 Feb 2019 10:56:53 -0300
> Paul Cercueil <paul@crapouillou.net> wrote:
>
>> Le dim. 3 févr. 2019 à 4:31, Boris Brezillon
>> <bbrezillon@kernel.org>
>> a écrit :
>> > On Sat, 2 Feb 2019 20:19:21 -0300
>> > Paul Cercueil <paul@crapouillou.net> wrote:
>> >
>> >> Add support for probing the jz4780-nand driver on the JZ4740 SoC
>> >> from
>> >> Ingenic.
>> >>
>> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> >> ---
>> >>
>> >> Changes:
>> >>
>> >> v2: - Add support for the JZ4740 and not the JZ4725B: they
>> behave
>> >> the
>> >> same, and JZ4740 is fully upstream while JZ4725B is not.
>> The
>> >> JZ4725B devicetree will then simply use the
>> >> "ingenic,jz4740-nand"
>> >> compatible string.
>> >> - Fix the number of bytes for the ECC when the ECC strength
>> is
>> >> 4.
>> >> This is needed for the JZ4740, which uses Reed-Solomon
>> >> instead of
>> >> BCH.
>> >>
>> >> drivers/mtd/nand/raw/ingenic/jz4780_nand.c | 48
>> >> +++++++++++++++++-----
>> >
>> > If we're going to make the driver compatible with jz4740 and
>> jz4725b
>> > maybe we should rename the source files jz47xx_{nand,bch}.{c,h}.
>>
>> I don't know about that. Adding support for new hardware isn't a
>> good
>> reason to
>> rename the driver, or so I've been told around here, as you then
>> make
>> it harder
>> to review the git history of the driver.
>
> You already move files to a sub-directory so that doesn't make a huge
> difference, history will be hard to follow because of this move
> anyway.

Yes, but if I merge the *_bch.c files together, and eventually drop
jz4740-nand.c, does it still make sense to move to a sub-directory?