From: Greg KH <gregkh@linuxfoundation.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: devicetree@vger.kernel.org, felipe.balbi@linux.intel.com,
mark.rutland@arm.com, linux-usb@vger.kernel.org,
hdegoede@redhat.com, heikki.krogerus@linux.intel.com,
andy.shevchenko@gmail.com, robh+dt@kernel.org, rogerq@ti.com,
linux-kernel@vger.kernel.org, jbergsagel@ti.com, nsekhar@ti.com,
nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com,
kurahul@cadence.com
Subject: Re: [PATCH v4 2/6] usb:common Separated decoding functions from dwc3 driver.
Date: Tue, 19 Feb 2019 14:14:02 +0100 [thread overview]
Message-ID: <20190219131402.GB20719@kroah.com> (raw)
In-Reply-To: <1550173514-23573-3-git-send-email-pawell@cadence.com>
On Thu, Feb 14, 2019 at 07:45:10PM +0000, Pawel Laszczak wrote:
> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver
> to driver/usb/common/debug.c file. These moved functions include:
> dwc3_decode_get_status
> dwc3_decode_set_clear_feature
> dwc3_decode_set_address
> dwc3_decode_get_set_descriptor
> dwc3_decode_get_configuration
> dwc3_decode_set_configuration
> dwc3_decode_get_intf
> dwc3_decode_set_intf
> dwc3_decode_synch_frame
> dwc3_decode_set_sel
> dwc3_decode_set_isoch_delay
> dwc3_decode_ctrl
>
> These functions are used also in inroduced cdns3 driver.
>
> All functions prefixes were changed from dwc3 to usb.
> Also, function's parameters has been extended according to the name
> of fields in standard SETUP packet.
> Additionally, patch adds usb_decode_ctrl function to
> include/linux/usb/ch9.h file.
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
> drivers/usb/common/Makefile | 2 +-
> drivers/usb/common/debug.c | 270 ++++++++++++++++++++++++++++++++++++
> drivers/usb/dwc3/debug.h | 249 ---------------------------------
> drivers/usb/dwc3/trace.h | 2 +-
> include/linux/usb/ch9.h | 25 ++++
> 5 files changed, 297 insertions(+), 251 deletions(-)
> create mode 100644 drivers/usb/common/debug.c
>
> diff --git a/drivers/usb/common/Makefile b/drivers/usb/common/Makefile
> index fb4d5ef4165c..3d3d2962ea4b 100644
> --- a/drivers/usb/common/Makefile
> +++ b/drivers/usb/common/Makefile
> @@ -4,7 +4,7 @@
> #
>
> obj-$(CONFIG_USB_COMMON) += usb-common.o
> -usb-common-y += common.o
> +usb-common-y += common.o debug.o
It's nice to have these in a common place, but you just bloated all of
the USB-enabled systems in the world for the use of 2 odd-ball system
controllers that almost no one has :)
So, any way to only pull in this file if you actually need these
functions?
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-19 13:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 19:45 [PATCH v4 0/6] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 1/6] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2019-02-18 16:46 ` Rob Herring
2019-02-14 19:45 ` [PATCH v4 2/6] usb:common Separated decoding functions from dwc3 driver Pawel Laszczak
2019-02-19 13:14 ` Greg KH [this message]
2019-02-20 6:28 ` Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 3/6] usb:common Patch simplify usb_decode_set_clear_feature function Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 4/6] usb:common Simplify usb_decode_get_set_descriptor function Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 5/6] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2019-02-15 9:57 ` Chunfeng Yun
2019-03-04 11:01 ` Pawel Laszczak
2019-03-04 12:46 ` Pawel Laszczak
2019-03-05 1:42 ` Chunfeng Yun
2019-02-19 13:24 ` Greg KH
2019-03-04 9:23 ` Pawel Laszczak
2019-02-20 13:04 ` Roger Quadros
2019-03-07 5:37 ` Pawel Laszczak
2019-03-11 11:53 ` Roger Quadros
2019-03-28 6:05 ` Pawel Laszczak
2019-02-21 9:22 ` Peter Chen
2019-03-07 9:52 ` Pawel Laszczak
2019-03-12 3:44 ` Peter Chen
2019-03-28 8:26 ` Pawel Laszczak
2019-02-14 19:45 ` [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer Pawel Laszczak
2019-02-20 10:24 ` Roger Quadros
2019-02-20 11:18 ` Pawel Laszczak
2019-02-20 13:17 ` Roger Quadros
2019-02-20 15:50 ` Pawel Laszczak
2019-02-21 7:14 ` Felipe Balbi
2019-03-04 10:25 ` Roger Quadros
2019-03-07 7:06 ` Pawel Laszczak
2019-03-07 9:13 ` Roger Quadros
2019-03-11 8:15 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219131402.GB20719@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox