From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F487C43381 for ; Tue, 19 Feb 2019 14:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C4B820700 for ; Tue, 19 Feb 2019 14:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728434AbfBSOEN (ORCPT ); Tue, 19 Feb 2019 09:04:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47200 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbfBSOEN (ORCPT ); Tue, 19 Feb 2019 09:04:13 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC46F81F31; Tue, 19 Feb 2019 14:04:12 +0000 (UTC) Received: from krava (unknown [10.43.17.42]) by smtp.corp.redhat.com (Postfix) with SMTP id 9BE1E173C1; Tue, 19 Feb 2019 14:04:10 +0000 (UTC) Date: Tue, 19 Feb 2019 15:04:09 +0100 From: Jiri Olsa To: Jonas Rabenstein Cc: linux-perf-users@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , Andi Kleen , Thomas Richter , Stephane Eranian , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf: fix HEADER_CMDLINE description in perf.data documentation Message-ID: <20190219140409.GD6435@krava> References: <20190218124648.GN31177@kernel.org> <20190218140203.1982-1-jonas.rabenstein@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190218140203.1982-1-jonas.rabenstein@studium.uni-erlangen.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 19 Feb 2019 14:04:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 18, 2019 at 03:02:03PM +0100, Jonas Rabenstein wrote: > The content of this feature header is a perf_header_string_list of > the argument vector and not a perf_header_string of the commandline. missing your Signed-off-by Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/Documentation/perf.data-file-format.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt > index dfb218feaad9..5f9a3924830b 100644 > --- a/tools/perf/Documentation/perf.data-file-format.txt > +++ b/tools/perf/Documentation/perf.data-file-format.txt > @@ -131,7 +131,7 @@ An uint64_t with the total memory in bytes. > > HEADER_CMDLINE = 11, > > -A perf_header_string with the perf command line used to collect the data. > +A perf_header_string_list with the perf arg-vector used to collect the data. > > HEADER_EVENT_DESC = 12, > > -- > 2.19.2 >