Re: [PATCH] x86/asm: Pin sensitive CR4 bits

Kees Cook
2019-02-20T17:01:03Z

On Tue, Feb 19, 2019 at 6:37 PM Jann Horn <jannh@google.com> wrote:
>
> On Wed, Feb 20, 2019 at 1:55 AM Kees Cook <keescook@chromium.org> wrote:
> > + if (WARN_ONCE(cr4_pin && (val & cr4_pin) == 0,
>
> Don't you mean `cr4_pin && (val & cr4_pin) != cr4_pin)`?

Whoops! Yes, thanks. :)

--
Kees Cook