Re: [PATCH RFC v2 2/4] PCI: pciehp: Do not turn off slot if presence comes up after link

Alex_Gagniuc
2019-02-22T19:56:44Z

On 2/21/19 1:36 AM, Lukas Wunner wrote:
> On Tue, Feb 19, 2019 at 07:20:28PM -0600, Alexandru Gagniuc wrote:
>> mutex_lock(&ctrl->state_lock);
>> + present = pciehp_card_present(ctrl);
>> + link_active = pciehp_check_link_active(ctrl);
>> switch (ctrl->state) {
>
> These two assignments appear to be superfluous as you're also performing
> them in pciehp_check_link_active().

Not sure. Between the first check, and this check, you can have several
seconds elapse depending on whether the driver's .probe()/remove() is
invoked. Whatever you got at the beginning would be stale. If you had a
picture dictionary and looked up 'bad idea', it would have a picture of
the above code with the second check removed.

I've got all the other review comments addressed in my local branch. I'm
waiting on Lord Helgass' decision on which solution is better.

Alex