From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nikolaus Voss <nv@vosn.de>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters
Date: Wed, 20 Feb 2019 17:22:14 +0100 [thread overview]
Message-ID: <20190220162214.GA2017@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1902201618090.8597@fox.voss.local>
On Wed, Feb 20, 2019 at 04:22:00PM +0100, Nikolaus Voss wrote:
> > > v2: fix tps6598x_exec_cmd also
> > > ---
> > > drivers/usb/typec/tps6598x.c | 26 ++++++++++++++++++++------
> > > 1 file changed, 20 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
> > > index c84c8c189e90..c54b73fb2a2f 100644
> > > --- a/drivers/usb/typec/tps6598x.c
> > > +++ b/drivers/usb/typec/tps6598x.c
> > > @@ -110,6 +110,20 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len)
> > > return 0;
> > > }
> > >
> > > +static int tps6598x_block_write(struct tps6598x *tps, u8 reg,
> > > + void *val, size_t len)
> > > +{
> > > + u8 data[len + 1];
> >
> > I thought the build system now warned when you did this :(
>
> I must admit I'm developing on 4.19 stable series, so no warnings...
Ick, no, you are 6 months behind where the rest of us are :(
Always, at the very least, work off of Linus's tree. For best results,
work off of linux-next.
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-20 16:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180425142209.30745-1-heikki.krogerus@linux.intel.com>
2018-09-10 5:05 ` [PATCH] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters Nikolaus Voss
2019-02-20 12:14 ` Heikki Krogerus
2019-02-20 12:56 ` Nikolaus Voss
2019-02-20 12:57 ` [PATCHv2] " Nikolaus Voss
2019-02-20 13:30 ` Heikki Krogerus
2019-02-20 13:38 ` Nikolaus Voss
2019-02-20 14:14 ` Heikki Krogerus
2019-02-20 14:30 ` Heikki Krogerus
2019-02-20 15:08 ` Nikolaus Voss
2019-02-20 14:45 ` Guenter Roeck
2019-02-20 15:18 ` Nikolaus Voss
2019-02-20 15:02 ` Greg Kroah-Hartman
2019-02-20 15:22 ` Nikolaus Voss
2019-02-20 16:22 ` Greg Kroah-Hartman [this message]
2019-02-21 8:37 ` Nikolaus Voss
2019-02-21 9:52 ` Greg Kroah-Hartman
2019-02-21 10:40 ` kbuild test robot
2019-02-20 15:11 ` [PATCHv3] " Nikolaus Voss
2019-02-20 15:35 ` Guenter Roeck
2019-02-20 15:36 ` Guenter Roeck
2019-02-21 8:41 ` Nikolaus Voss
2019-02-21 9:08 ` Heikki Krogerus
2019-02-21 9:42 ` Nikolaus Voss
2019-02-21 9:52 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220162214.GA2017@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nv@vosn.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox