From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8864C43381 for ; Wed, 20 Feb 2019 22:31:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79CB320836 for ; Wed, 20 Feb 2019 22:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbfBTWbh (ORCPT ); Wed, 20 Feb 2019 17:31:37 -0500 Received: from muru.com ([72.249.23.125]:39962 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbfBTWbg (ORCPT ); Wed, 20 Feb 2019 17:31:36 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 38E2F80E1; Wed, 20 Feb 2019 22:31:46 +0000 (UTC) Date: Wed, 20 Feb 2019 14:31:32 -0800 From: Tony Lindgren To: Andreas Kemnade Cc: Dmitry Torokhov , kishon@ti.com, lee.jones@linaro.org, daniel.thompson@linaro.org, wsa@the-dreams.de, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Discussions about the Letux Kernel Subject: Re: [PATCH v2] phy: phy-twl4030-usb: fix denied runtime access Message-ID: <20190220223132.GV15711@atomide.com> References: <20180922094405.4067-1-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180922094405.4067-1-andreas@kemnade.info> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andreas Kemnade [180922 09:48]: > When runtime is not enabled, pm_runtime_get_sync() returns -EACCESS, > the counter will be incremented but the resume callback not called, > so enumeration and charging will not start properly. > To avoid that happen, disable irq on suspend and recheck on resume. > > Practically this happens when the device is woken up from suspend by > plugging in usb. > > Signed-off-by: Andreas Kemnade > --- > Changes in v2: > * use pm suspend/resume callback instead of delayed_work > as suggested by Dmitry Hmm it just occurred to me that this issue too might be fixed with commit c6e2bd956936 ("i2c: omap: Use noirq system sleep pm ops to idle device for suspend"). Andreas, care to check? That is if this is still an issue. Regards, Tony