public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Matt Hsiao <matt.hsiao@hpe.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
	david.altobelli@hpe.com, mark.rusk@hpe.com,
	jerry.hoemann@hpe.com
Subject: Re: [PATCH 4/4] misc: hpilo: Update driver version
Date: Thu, 21 Feb 2019 09:32:56 +0100	[thread overview]
Message-ID: <20190221083256.GA6397@kroah.com> (raw)
In-Reply-To: <1550736282-25416-5-git-send-email-matt.hsiao@hpe.com>

On Thu, Feb 21, 2019 at 04:04:42PM +0800, Matt Hsiao wrote:
> Bump version number to reflect recent minor changes.
> 
> Signed-off-by: Matt Hsiao <matt.hsiao@hpe.com>
> ---
>  drivers/misc/hpilo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
> index 927309b..4ef6802 100644
> --- a/drivers/misc/hpilo.c
> +++ b/drivers/misc/hpilo.c
> @@ -913,7 +913,7 @@ static void __exit ilo_exit(void)
>  	class_destroy(ilo_class);
>  }
>  
> -MODULE_VERSION("1.5.0");
> +MODULE_VERSION("1.5.1");

This line means nothing, it should just be removed entirely.  The
"version" of the driver is the kernel version itself.

Want me to drop it?

thanks,

greg k-h

  reply	other threads:[~2019-02-21  8:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21  8:04 [PATCH 0/4] misc: hpilo: Do not claim on unsupported hardware Matt Hsiao
2019-02-21  8:04 ` [PATCH 1/4] misc: hpilo: Be more specific when ignoring the aux iLO Matt Hsiao
2019-02-21  8:04 ` [PATCH 2/4] misc: hpilo: Exclude unsupported device via blacklist Matt Hsiao
2019-02-21  8:33   ` Greg KH
2019-02-22  4:35     ` Jerry Hoemann
2019-02-22  6:50       ` Greg KH
2019-02-21  8:04 ` [PATCH 3/4] misc: hpilo: Do not claim unsupported hardware Matt Hsiao
2019-02-21  8:35   ` Greg KH
2019-02-22  3:59     ` Jerry Hoemann
2019-02-21  8:04 ` [PATCH 4/4] misc: hpilo: Update driver version Matt Hsiao
2019-02-21  8:32   ` Greg KH [this message]
2019-02-22  4:11     ` Jerry Hoemann
2019-02-22  6:49       ` Greg KH
2019-02-25  8:28         ` Jerry Hoemann
2019-02-25 21:44           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190221083256.GA6397@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=david.altobelli@hpe.com \
    --cc=jerry.hoemann@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rusk@hpe.com \
    --cc=matt.hsiao@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox