From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB33C4360F for ; Thu, 21 Feb 2019 14:39:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A4662084D for ; Thu, 21 Feb 2019 14:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550759977; bh=llZcv5zpIl5ZO+7Nla5wMEQhNzDUItlpEyLxq8UcymI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gDkGBFMk08Npy9kD3XfBjZOAtUbwjZH8bhhS1LG9Z4+Eic8oJpV70vH0ZA8N47Vlj jlfwf9lzj/7b0H9NwqTl51lsieFxde/KZA0HNxXQ8BXHXSZH3cwT8tyqDFUwTbR706 Z+m651ehaJdo/1fR2A2mmmZPtOZtSfMszUCbkV+4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728945AbfBUOjg (ORCPT ); Thu, 21 Feb 2019 09:39:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:33540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728926AbfBUOjd (ORCPT ); Thu, 21 Feb 2019 09:39:33 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 510A42084F; Thu, 21 Feb 2019 14:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550759972; bh=llZcv5zpIl5ZO+7Nla5wMEQhNzDUItlpEyLxq8UcymI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0IGZK+SwbRoFuC5UV02RnW6NT730m6A7TFb8ppPT5RCgw/u7X9zC/ILgyCnvL/UAE Pm931rsGwJAXE8U3HJsNWUTfJ28U/fMxTtTra8qGXYI7CmqYozb+SaDuMG1ssu5U81 FaC24FpnxUBOeJFwJ0a5WEd1l6y7A4DZOKDpe0fw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Kocialkowski , "David S. Miller" Subject: [PATCH 4.14 10/23] net: phy: xgmiitorgmii: Support generic PHY status read Date: Thu, 21 Feb 2019 15:35:52 +0100 Message-Id: <20190221125247.067935248@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190221125246.162644302@linuxfoundation.org> References: <20190221125246.162644302@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Paul Kocialkowski [ Upstream commit 197f9ab7f08ce4b9ece662f747c3991b2f0fbb57 ] Some PHY drivers like the generic one do not provide a read_status callback on their own but rely on genphy_read_status being called directly. With the current code, this results in a NULL function pointer call. Call genphy_read_status instead when there is no specific callback. Fixes: f411a6160bd4 ("net: phy: Add gmiitorgmii converter support") Signed-off-by: Paul Kocialkowski Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/xilinx_gmii2rgmii.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/net/phy/xilinx_gmii2rgmii.c +++ b/drivers/net/phy/xilinx_gmii2rgmii.c @@ -42,7 +42,10 @@ static int xgmiitorgmii_read_status(stru u16 val = 0; int err; - err = priv->phy_drv->read_status(phydev); + if (priv->phy_drv->read_status) + err = priv->phy_drv->read_status(phydev); + else + err = genphy_read_status(phydev); if (err < 0) return err;