From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-kernel@vger.kernel.org, Zhi Jin <zhi.jin@intel.com>
Subject: Re: [GIT PULL 6/7] stm class: Fix an endless loop in channel allocation
Date: Thu, 21 Feb 2019 15:42:17 +0100 [thread overview]
Message-ID: <20190221144217.GB9283@kroah.com> (raw)
In-Reply-To: <20190221134959.15121-7-alexander.shishkin@linux.intel.com>
On Thu, Feb 21, 2019 at 03:49:58PM +0200, Alexander Shishkin wrote:
> From: Zhi Jin <zhi.jin@intel.com>
>
> There is a bug in the channel allocation logic that leads to an endless
> loop when looking for a contiguous range of channels in a range with a
> mixture of free and occupied channels. For example, opening three
> consequtive channels, closing the first two and requesting 4 channels in
> a row will trigger this soft lockup. The bug is that the search loop
> forgets to skip over the range once it detects that one channel in that
> range is occupied.
>
> Restore the original intent to the logic by fixing the omission.
>
> Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
> Signed-off-by: Zhi Jin <zhi.jin@intel.com>
> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
This should have a cc: stable in it, right?
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-21 14:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 13:49 [GIT PULL 0/7] stm class/intel_th: Updates for v5.1 Alexander Shishkin
2019-02-21 13:49 ` [GIT PULL 1/7] intel_th: Update ABI documentation Alexander Shishkin
2019-02-21 13:49 ` [GIT PULL 2/7] intel_th: Mark expected switch fall-throughs Alexander Shishkin
2019-02-21 13:49 ` [GIT PULL 3/7] intel_th: Only create useful device nodes Alexander Shishkin
2019-02-21 13:49 ` [GIT PULL 4/7] intel_th: pti: Use sysfs_match_string() helper Alexander Shishkin
2019-02-21 13:49 ` [GIT PULL 5/7] intel_th: Don't reference unassigned outputs Alexander Shishkin
2019-02-21 14:41 ` Greg Kroah-Hartman
2019-02-21 13:49 ` [GIT PULL 6/7] stm class: Fix an endless loop in channel allocation Alexander Shishkin
2019-02-21 14:42 ` Greg Kroah-Hartman [this message]
2019-02-21 13:49 ` [GIT PULL 7/7] stm class: Prevent division by zero Alexander Shishkin
2019-02-21 14:42 ` Greg Kroah-Hartman
2019-02-21 14:52 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221144217.GB9283@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=zhi.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox