From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [GIT PULL v1 4/7] intel_th: pti: Use sysfs_match_string() helper
Date: Thu, 21 Feb 2019 17:50:03 +0200 [thread overview]
Message-ID: <20190221155006.76832-5-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <20190221155006.76832-1-alexander.shishkin@linux.intel.com>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Use sysfs_match_string() helper instead of open coded variant.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
drivers/hwtracing/intel_th/pti.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/hwtracing/intel_th/pti.c b/drivers/hwtracing/intel_th/pti.c
index 56694339cb06..0da6b787f553 100644
--- a/drivers/hwtracing/intel_th/pti.c
+++ b/drivers/hwtracing/intel_th/pti.c
@@ -272,19 +272,17 @@ static ssize_t lpp_dest_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t size)
{
struct pti_device *pti = dev_get_drvdata(dev);
- ssize_t ret = -EINVAL;
int i;
- for (i = 0; i < ARRAY_SIZE(lpp_dest_str); i++)
- if (sysfs_streq(buf, lpp_dest_str[i]))
- break;
+ i = sysfs_match_string(lpp_dest_str, buf);
+ if (i < 0)
+ return i;
- if (i < ARRAY_SIZE(lpp_dest_str) && pti->lpp_dest_mask & BIT(i)) {
- pti->lpp_dest = i;
- ret = size;
- }
+ if (!(pti->lpp_dest_mask & BIT(i)))
+ return -EINVAL;
- return ret;
+ pti->lpp_dest = i;
+ return size;
}
static DEVICE_ATTR_RW(lpp_dest);
--
2.20.1
next prev parent reply other threads:[~2019-02-21 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 15:49 [GIT PULL v1 0/7] stm class/intel_th: Updates for v5.1 Alexander Shishkin
2019-02-21 15:50 ` [GIT PULL v1 1/7] intel_th: Update ABI documentation Alexander Shishkin
2019-02-21 15:50 ` [GIT PULL v1 2/7] intel_th: Mark expected switch fall-throughs Alexander Shishkin
2019-02-21 15:50 ` [GIT PULL v1 3/7] intel_th: Only create useful device nodes Alexander Shishkin
2019-02-21 15:50 ` Alexander Shishkin [this message]
2019-02-21 15:50 ` [GIT PULL v1 5/7] intel_th: Don't reference unassigned outputs Alexander Shishkin
2019-02-21 15:50 ` [GIT PULL v1 6/7] stm class: Fix an endless loop in channel allocation Alexander Shishkin
2019-02-21 15:50 ` [GIT PULL v1 7/7] stm class: Prevent division by zero Alexander Shishkin
2019-02-21 16:13 ` [GIT PULL v1 0/7] stm class/intel_th: Updates for v5.1 Greg Kroah-Hartman
2019-03-01 8:12 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221155006.76832-5-alexander.shishkin@linux.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox