From: Daniel Vetter <daniel@ffwll.ch>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Noralf Trønnes" <noralf@tronnes.org>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"open list:INTEL DRM DRIVERS excluding Poulsbo,
Moorestow..." <intel-gfx@lists.freedesktop.org>,
"open list" <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
"David Airlie" <airlied@linux.ie>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Sean Paul" <sean@poorly.run>
Subject: Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper
Date: Thu, 21 Feb 2019 16:51:34 +0100 [thread overview]
Message-ID: <20190221155134.GU2665@phenom.ffwll.local> (raw)
In-Reply-To: <20190221150912.yytlcxxwv7qodaf3@sirius.home.kraxel.org>
On Thu, Feb 21, 2019 at 04:09:12PM +0100, Gerd Hoffmann wrote:
> > > +int drm_fb_helper_kick_out_vgacon(void);
> > > +
> >
> > Don't you need a dummy version as well for this one, like how it's done
> > for the other functions, to cover the case when DRM_FBDEV_EMULATION is
> > not selected?
>
> Good question.
>
> I guess it makes sense to kick out vgacon even with CONFIG_FB=n.
>
> But when integrating this into
> drm_fb_helper_remove_conflicting_pci_framebuffers() as suggested by
> Daniel this isn't going to fly ...
We need to put it into both versions of that function, or pull that
function out of the #ifdef.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2019-02-21 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190221113534.20764-1-kraxel@redhat.com>
2019-02-21 11:35 ` [PATCH v2 2/2] drm/qxl: kick out vgacon Gerd Hoffmann
2019-02-21 12:20 ` Daniel Vetter
2019-02-21 13:06 ` Gerd Hoffmann
2019-02-21 14:24 ` Daniel Vetter
2019-02-21 15:11 ` Gerd Hoffmann
2019-02-21 15:17 ` Daniel Vetter
2019-02-22 7:14 ` Gerd Hoffmann
[not found] ` <20190221113534.20764-2-kraxel@redhat.com>
2019-02-21 13:08 ` [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper Jani Nikula
2019-02-21 13:25 ` Gerd Hoffmann
2019-02-21 14:41 ` Jani Nikula
2019-02-21 14:12 ` Noralf Trønnes
2019-02-21 15:09 ` Gerd Hoffmann
2019-02-21 15:51 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221155134.GU2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=noralf@tronnes.org \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox