From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52402C43381 for ; Thu, 21 Feb 2019 16:47:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E65A2083E for ; Thu, 21 Feb 2019 16:47:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AsBsO55C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726525AbfBUQrK (ORCPT ); Thu, 21 Feb 2019 11:47:10 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:38828 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725943AbfBUQrK (ORCPT ); Thu, 21 Feb 2019 11:47:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pGHJrwXYyWdu/ZzuzXQKBT8exGhGYvkDIyG1GOMNns0=; b=AsBsO55C1xcCrdixr2qL829WQ QaW4xlXg+Juc+DnxPlPGZsJ/kqPJkz+tIoE16eOELDAV6RuX22TdBQtLg7NKe8ZZqlce3zVgUvt/n g+8biF3vkalax1n32LdkN0lqREn5bLcpGM615TAKwRtkG3kJauIOVfMeRyhQjmu5ZmZ9hIsCFnh8Z nEpmdOzj24OeyHuhwpice6YxZO9tLy78FGrmwsbM30AnyPDUo7W5UxZjOubj4YpQqFglYwz4Ho9h1 1431Yaabt4c4OvnpWKCKi6X2MOi4X/omxh2cyolZecOnt33jRT/P2P95VxAi72iA5oAfLN4v57/ZQ K1E3o9L7Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwrV2-0003yj-PL; Thu, 21 Feb 2019 16:47:04 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id F3E4D22BBEAF4; Thu, 21 Feb 2019 17:47:02 +0100 (CET) Date: Thu, 21 Feb 2019 17:47:02 +0100 From: Peter Zijlstra To: Valentin Schneider Cc: mingo@kernel.org, tglx@linutronix.de, pjt@google.com, tim.c.chen@linux.intel.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, subhra.mazumdar@oracle.com, fweisbec@gmail.com, keescook@chromium.org, kerrnel@google.com Subject: Re: [RFC][PATCH 15/16] sched: Trivial forced-newidle balancer Message-ID: <20190221164702.GY32534@hirez.programming.kicks-ass.net> References: <20190218165620.383905466@infradead.org> <20190218173514.796920915@infradead.org> <20190221164146.GV32494@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190221164146.GV32494@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 21, 2019 at 05:41:46PM +0100, Peter Zijlstra wrote: > On Thu, Feb 21, 2019 at 04:19:46PM +0000, Valentin Schneider wrote: > > Hi, > > > > On 18/02/2019 16:56, Peter Zijlstra wrote: > > [...] > > > +static bool try_steal_cookie(int this, int that) > > > +{ > > > + struct rq *dst = cpu_rq(this), *src = cpu_rq(that); > > > + struct task_struct *p; > > > + unsigned long cookie; > > > + bool success = false; > > > + > > > + local_irq_disable(); > > > + double_rq_lock(dst, src); > > > + > > > + cookie = dst->core->core_cookie; > > > + if (!cookie) > > > + goto unlock; > > > + > > > + if (dst->curr != dst->idle) > > > + goto unlock; > > > + > > > + p = sched_core_find(src, cookie); > > > + if (p == src->idle) > > > + goto unlock; > > > + > > > + do { > > > + if (p == src->core_pick || p == src->curr) > > > + goto next; > > > + > > > + if (!cpumask_test_cpu(this, &p->cpus_allowed)) > > > + goto next; > > > + > > > + if (p->core_occupation > dst->idle->core_occupation) > > > + goto next; > > > + > > > > IIUC, we're trying to find/steal tasks matching the core_cookie from other > > rqs because dst has been cookie-forced-idle. > > > > If the p we find isn't running, what's the meaning of core_occupation? > > I would have expected it to be 0, but we don't seem to be clearing it when > > resetting the state in pick_next_task(). > > Indeed. We preserve the occupation from the last time around; it's not > perfect but its better than nothing. > > Consider there's two groups; and we just happen to run the other group. > Then our occopation, being what it was last, is still accurate. When > next we run, we'll again get that many siblings together. > > > If it is running, we prevent the stealing if the core it's on is running > > more matching tasks than the core of the pulling rq. It feels to me as if > > that's a balancing tweak to try to cram as many matching tasks as possible > > in a single core, so to me this reads as "don't steal my tasks if I'm > > running more than you are, but I will steal tasks from you if I'm given > > the chance". Is that correct? > > Correct, otherwise an SMT4 with 5 tasks could end up ping-ponging the > one task forever. > > Note that a further condition a little up the callchain from here only > does this stealing if the thread was forced-idle -- ie. it had something > to run anyway. So under the condition where there simple aren't enough > tasks to keep all siblings busy, we'll not compact just cause. Better example; it will avoid stealing a task from a full SMT2 core to fill another.