From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D97C43381 for ; Thu, 21 Feb 2019 21:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C4BB20818 for ; Thu, 21 Feb 2019 21:27:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726706AbfBUV1y (ORCPT ); Thu, 21 Feb 2019 16:27:54 -0500 Received: from muru.com ([72.249.23.125]:40174 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725802AbfBUV1y (ORCPT ); Thu, 21 Feb 2019 16:27:54 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 797C280C8; Thu, 21 Feb 2019 21:28:03 +0000 (UTC) Date: Thu, 21 Feb 2019 13:27:49 -0800 From: Tony Lindgren To: Andreas Kemnade Cc: Dmitry Torokhov , kishon@ti.com, lee.jones@linaro.org, daniel.thompson@linaro.org, wsa@the-dreams.de, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Discussions about the Letux Kernel Subject: Re: [PATCH v2] phy: phy-twl4030-usb: fix denied runtime access Message-ID: <20190221212749.GZ15711@atomide.com> References: <20180922094405.4067-1-andreas@kemnade.info> <20190220223132.GV15711@atomide.com> <20190221170840.5c970def@kemnade.info> <20190221164803.GX15711@atomide.com> <20190221203958.66d904f6@aktux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190221203958.66d904f6@aktux> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andreas Kemnade [190221 19:40]: > On Thu, 21 Feb 2019 08:48:03 -0800 > Tony Lindgren wrote: > > > * Andreas Kemnade [190221 16:43]: > > > Hi, > > > > > > On Wed, 20 Feb 2019 14:31:32 -0800 > > > Tony Lindgren wrote: > > > > > > > * Andreas Kemnade [180922 09:48]: > > > > > When runtime is not enabled, pm_runtime_get_sync() returns -EACCESS, > > > > > the counter will be incremented but the resume callback not called, > > > > > so enumeration and charging will not start properly. > > > > > To avoid that happen, disable irq on suspend and recheck on resume. > > > > > > > > > > Practically this happens when the device is woken up from suspend by > > > > > plugging in usb. > > > > > > > > > > Signed-off-by: Andreas Kemnade > > > > > --- > > > > > Changes in v2: > > > > > * use pm suspend/resume callback instead of delayed_work > > > > > as suggested by Dmitry > > > > > > > > Hmm it just occurred to me that this issue too might be fixed with commit > > > > c6e2bd956936 ("i2c: omap: Use noirq system sleep pm ops to idle device > > > > for suspend"). Andreas, care to check? That is if this is still an > > > > issue. > > > > > > > this one made already its way into 4.20. But for the records, I will > > > build the latest 5.0-rc and revert it and will check if the problem > > > still occurs. > > > > OK thanks. > > > first of all, suspend is totally broken in v5.0-rc7. > I booted with init=/bin/bash > and just loaded gpio-twl4030 and twl4030-pwrbutton > > and did (rtc in compiled in) a > root@(none):/# rtcwake -s 10 -m mem > rtcwake: wakeup from "mem" using /dev/rtc0 at Sat Jan 1 00:05:24 2000 > [ 86.434722] PM: suspend entry (deep) > [ 86.438842] PM: Syncing filesystems ... done. > [ 86.458770] Freezing user space processes ... (elapsed 0.003 seconds) done. > [ 86.470947] OOM killer disabled. > [ 86.474365] Freezing remaining freezable tasks ... (elapsed 0.002 seconds) done. > [ 86.485473] printk: Suspending console(s) (use no_console_suspend to debug) > [ 86.555572] Disabling non-boot CPUs ... > [ 86.555664] Successfully put all powerdomains to target state > [ 86.563720] twl: Read failed (mod 1, reg 0x01 count 1) > [ 86.563751] twl4030: I2C error -13 reading PIH ISR > [ 86.563812] twl: Read failed (mod 1, reg 0x01 count 1) > [ 86.563812] twl4030: I2C error -13 reading PIH ISR > [ 86.563873] twl: Read failed (mod 1, reg 0x01 count 1) > [ 86.563903] twl4030: I2C error -13 reading PIH ISR > > and this goes on forever. > I will try to bisect that. Strange, I'm not seeing that here. Anyways let's debug more in your bisect email thread. Thanks, Tony