From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D550CC43381 for ; Fri, 22 Feb 2019 03:42:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FD3E2080F for ; Fri, 22 Feb 2019 03:42:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbfBVDmj (ORCPT ); Thu, 21 Feb 2019 22:42:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39276 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbfBVDmj (ORCPT ); Thu, 21 Feb 2019 22:42:39 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 537BB81F11; Fri, 22 Feb 2019 03:42:38 +0000 (UTC) Received: from xz-x1 (ovpn-12-57.pek2.redhat.com [10.72.12.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 246CD60C80; Fri, 22 Feb 2019 03:42:22 +0000 (UTC) Date: Fri, 22 Feb 2019 11:42:14 +0800 From: Peter Xu To: Jerome Glisse Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Hugh Dickins , Maya Gokhale , Pavel Emelyanov , Johannes Weiner , Martin Cracauer , Shaohua Li , Marty McFadden , Andrea Arcangeli , Mike Kravetz , Denis Plotnikov , Mike Rapoport , Mel Gorman , "Kirill A . Shutemov" , "Dr . David Alan Gilbert" Subject: Re: [PATCH v2 01/26] mm: gup: rename "nonblocking" to "locked" where proper Message-ID: <20190222034214.GB8904@xz-x1> References: <20190212025632.28946-1-peterx@redhat.com> <20190212025632.28946-2-peterx@redhat.com> <20190221151742.GA2813@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190221151742.GA2813@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 22 Feb 2019 03:42:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 21, 2019 at 10:17:42AM -0500, Jerome Glisse wrote: > On Tue, Feb 12, 2019 at 10:56:07AM +0800, Peter Xu wrote: > > There's plenty of places around __get_user_pages() that has a parameter > > "nonblocking" which does not really mean that "it won't block" (because > > it can really block) but instead it shows whether the mmap_sem is > > released by up_read() during the page fault handling mostly when > > VM_FAULT_RETRY is returned. > > > > We have the correct naming in e.g. get_user_pages_locked() or > > get_user_pages_remote() as "locked", however there're still many places > > that are using the "nonblocking" as name. > > > > Renaming the places to "locked" where proper to better suite the > > functionality of the variable. While at it, fixing up some of the > > comments accordingly. > > > > Reviewed-by: Mike Rapoport > > Signed-off-by: Peter Xu > > Minor issue see below > > Reviewed-by: Jérôme Glisse > > [...] > > > @@ -656,13 +656,11 @@ static int check_vma_flags(struct vm_area_struct *vma, unsigned long gup_flags) > > * appropriate) must be called after the page is finished with, and > > * before put_page is called. > > * > > - * If @nonblocking != NULL, __get_user_pages will not wait for disk IO > > - * or mmap_sem contention, and if waiting is needed to pin all pages, > > - * *@nonblocking will be set to 0. Further, if @gup_flags does not > > - * include FOLL_NOWAIT, the mmap_sem will be released via up_read() in > > - * this case. > > + * If @locked != NULL, *@locked will be set to 0 when mmap_sem is > > + * released by an up_read(). That can happen if @gup_flags does not > > + * has FOLL_NOWAIT. > > I am not a native speaker but i believe the correct wording is: > @gup_flags does not have FOLL_NOWAIT Yes I agree. (r-b taken, and I kept Mike's too assuming this is a trivial change) Thanks! -- Peter Xu