From: Masami Hiramatsu <mhiramat@kernel.org>
To: Juerg Haefliger <juerg.haefliger@canonical.com>,
Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org,
mingo@redhat.com, Juerg Haefliger <juergh@canonical.com>
Subject: Re: [PATCH v2 2/2] selftests/ftrace: Replace \e with \033
Date: Fri, 22 Feb 2019 23:59:15 +0900 [thread overview]
Message-ID: <20190222235915.bdf82008eef24f8189bd33ec@kernel.org> (raw)
In-Reply-To: <20190222091021.10178-3-juergh@canonical.com>
On Fri, 22 Feb 2019 10:10:21 +0100
Juerg Haefliger <juerg.haefliger@canonical.com> wrote:
> The \e sequence character is not POSIX. Fix that by using \033 instead.
>
> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
This also looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
> ---
> tools/testing/selftests/ftrace/ftracetest | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index 20c9c0ad8682..136387422b00 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -161,10 +161,10 @@ color_green=
> color_blue=
> # If stdout exists and number of colors is eight or more, use them
> if [ -t 1 -a "$ncolors" -ge 8 ]; then
> - color_reset="\e[0m"
> - color_red="\e[31m"
> - color_green="\e[32m"
> - color_blue="\e[34m"
> + color_reset="\033[0m"
> + color_red="\033[31m"
> + color_green="\033[32m"
> + color_blue="\033[34m"
> fi
>
> strip_esc() {
> --
> 2.19.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2019-02-22 14:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 16:13 [PATCH] selftests/ftrace: Make the coloring POSIX compliant Juerg Haefliger
2019-02-20 19:49 ` Steven Rostedt
2019-02-20 20:20 ` Juerg Haefliger
2019-02-20 20:33 ` Adam Borowski
2019-02-22 0:29 ` Masami Hiramatsu
2019-02-22 9:10 ` [PATCH v2 0/2] selftests/ftrace: Make ftracetest " Juerg Haefliger
2019-02-22 9:10 ` [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 14:58 ` Masami Hiramatsu
2019-02-22 15:58 ` shuah
2019-02-22 9:10 ` [PATCH v2 2/2] selftests/ftrace: Replace \e with \033 Juerg Haefliger
2019-02-22 14:59 ` Masami Hiramatsu [this message]
2019-02-22 15:59 ` shuah
2019-02-22 19:03 ` Steven Rostedt
2019-02-22 20:52 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
2019-02-22 20:52 ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 22:33 ` shuah
2019-02-22 20:53 ` [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033 Juerg Haefliger
2019-02-22 22:46 ` shuah
2019-02-23 12:25 ` Juerg Haefliger
2019-02-25 13:00 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222235915.bdf82008eef24f8189bd33ec@kernel.org \
--to=mhiramat@kernel.org \
--cc=juerg.haefliger@canonical.com \
--cc=juergh@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox