public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bo YU <tsu.yubo@gmail.com>
Cc: gregkh@linuxfoundation.org, sergio.paracuellos@gmail.com,
	quytelda@tamalin.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, yuzibode@126.com
Subject: Re: [PATCH] staging/ks7070: Removed unused varibale
Date: Sat, 23 Feb 2019 10:18:12 +0300	[thread overview]
Message-ID: <20190223071812.GE1737@kadam> (raw)
In-Reply-To: <20190223063939.18261-1-tsu.yubo@gmail.com>

On Sat, Feb 23, 2019 at 01:39:39AM -0500, Bo YU wrote:
> From: Bo Yu <tsu.yubo@gmail.com>
> 
> Compiling the kernel with W=1 results in the following warning:
> 
> drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’
> set but not used [-Wunused-but-set-variable]
>   u16 mib_val_type;
> 
> drivers/staging/ks7010/ks_hostif.c:464:6: warning: variable ‘mib_val_size’
> set but not used [-Wunused-but-set-variable]
>     u16 mib_val_size;
> 
> drivers/staging/ks7010/ks_hostif.c:786:6: warning: variable ‘result_code’
> set but not used [-Wunused-but-set-variable]
>       u16 result_code;
> 
> Remove these variables.
> 
> Rebase on next-20190222
  ^^^^^^^^^^^^^^^^^^^^^^^
Is this a v2 patch or something?  Don't include this in the changelog.
Put it under the --- cut off line.

> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> Cc: Quytelda Kahja <quytelda@tamalin.org>
> 
> Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
> ---
  ^^^

>  drivers/staging/ks7010/ks_hostif.c | 6 ------
>  1 file changed, 6 deletions(-)
> 

regards,
dan carpenter

  parent reply	other threads:[~2019-02-23  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-23  6:39 [PATCH] staging/ks7070: Removed unused varibale Bo YU
2019-02-23  6:46 ` Sergio Paracuellos
2019-02-23  7:18 ` Dan Carpenter [this message]
2019-02-23  7:43 ` Greg KH
2019-02-23  8:09   ` YU Bo
2019-02-23  8:38     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190223071812.GE1737@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quytelda@tamalin.org \
    --cc=sergio.paracuellos@gmail.com \
    --cc=tsu.yubo@gmail.com \
    --cc=yuzibode@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox