From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB195C43381 for ; Mon, 25 Feb 2019 16:02:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B23A20842 for ; Mon, 25 Feb 2019 16:02:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Hb2CwwPF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbfBYQCf (ORCPT ); Mon, 25 Feb 2019 11:02:35 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:44794 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727731AbfBYQCe (ORCPT ); Mon, 25 Feb 2019 11:02:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=66YT2ZgedMRxeKmlzocG77g0pVreYAX15nL55pvCTdw=; b=Hb2CwwPFr9gn1yTtE3yqDXUt7 jysuWTuQfHiXzP3wst55xdjPb8b7SAXiaBQkZYdTt5aehaJjLvpOrs8LlqwTSZ/uGAPyaEmt8MA+J 4Vq6xAdn1vSUteFz6OM9I+2UFnKVMJl52Lr/8Sy58zU+HcftnBqoCVwUs8vKQGiHl9ESumETHDMrg F84tSasbmooQz0rnC1I/oAcZsK6S+2lpaSAGSfVkE7a7bC99NgT3otV/u4RjUWzqsLppzMt1po/u2 CfbMl60afHxFhzCEJKGBcWXu6/pNJgPXl89g0AojHyuZQQNUIBK4UpRvRAalMM1cFL2xneTVpWNjV pjhMQo02A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gyIi2-0007jh-1q; Mon, 25 Feb 2019 16:02:26 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3E40220277F84; Mon, 25 Feb 2019 17:02:23 +0100 (CET) Date: Mon, 25 Feb 2019 17:02:23 +0100 From: Peter Zijlstra To: Andy Lutomirski Cc: Linus Torvalds , Thomas Gleixner , "H. Peter Anvin" , Julien Thierry , Will Deacon , Ingo Molnar , Catalin Marinas , James Morse , valentin.schneider@arm.com, Brian Gerst , Josh Poimboeuf , Andrew Lutomirski , Borislav Petkov , Denys Vlasenko , LKML Subject: Re: [PATCH 1/6] x86/uaccess: Dont evaluate argument inside AC region Message-ID: <20190225160223.GK32477@hirez.programming.kicks-ass.net> References: <20190225124330.613028745@infradead.org> <20190225125231.845656645@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 25, 2019 at 07:43:53AM -0800, Andy Lutomirski wrote: > On Mon, Feb 25, 2019 at 4:53 AM Peter Zijlstra wrote: > > > > AC regions are special, make sure we don't do possibly complex > > evaluations there. > > > > Probably-Signed-off-by: Andy Lutomirski > > I put a slightly fancier version here last night so that the 0day bot > could chew on it: > > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/fixes&id=b294da548d92320f194172272dda1f734e51013d > > want to snarf it up? It's the same thing except that I added Linus' > suggested change, found the offending patch that broke it (hi Linus!) > and added a bit more changelog :) Sure; I'll take that one.