From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E1ADC43381 for ; Mon, 25 Feb 2019 21:17:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1337217F5 for ; Mon, 25 Feb 2019 21:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129421; bh=rutuRzkrjr9PMpPcdeDLubuacW2AFb2hswff35gW7H8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FqJpR/Odt2rz+xv20Dl3Aoq3yXEbpzbtUGsFh5DODkOD3Wlq6svoQIAKpBwlI6agz 6vmd0An3ZB0E6FZaG0PgQRAoIMoLdIMtTzE8f+p5ejtHnsd+LB3gQsEzedKzSMMhxT vzuqM6z2LimkvGoNiEdNF9Yo+Xe7i5Z5daWJTqL4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729835AbfBYVRA (ORCPT ); Mon, 25 Feb 2019 16:17:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:48902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729091AbfBYVQ5 (ORCPT ); Mon, 25 Feb 2019 16:16:57 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E00402147C; Mon, 25 Feb 2019 21:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129417; bh=rutuRzkrjr9PMpPcdeDLubuacW2AFb2hswff35gW7H8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lBTRxtvfuerniYQa5zog3pqTsCoPnPMZWocxjgDHGHXuZNIqRPhys0Ki08DKmzYOZ Jk7EgVms2FGVWk3zwORuVJfik1ufddwYc3Was5WTBnjuapEkSUOOy703Qd/Xg7KKAF hxmyPTfSvMCdan+gRvAF6jknX2/qOSrFHtDwyCPg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Denis Bolotin , Ariel Elior , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 24/71] qed: Fix qed_ll2_post_rx_buffer_notify_fw() by adding a write memory barrier Date: Mon, 25 Feb 2019 22:11:26 +0100 Message-Id: <20190225195036.326581368@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195034.555044862@linuxfoundation.org> References: <20190225195034.555044862@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 46721c3d9e273aea880e9ff835b0e1271e1cd2fb ] Make sure chain element is updated before ringing the doorbell. Signed-off-by: Denis Bolotin Signed-off-by: Ariel Elior Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c index b73bcbeb5f279..cef619f0ce10b 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c @@ -1487,6 +1487,10 @@ static void qed_ll2_post_rx_buffer_notify_fw(struct qed_hwfn *p_hwfn, cq_prod = qed_chain_get_prod_idx(&p_rx->rcq_chain); rx_prod.bd_prod = cpu_to_le16(bd_prod); rx_prod.cqe_prod = cpu_to_le16(cq_prod); + + /* Make sure chain element is updated before ringing the doorbell */ + dma_wmb(); + DIRECT_REG_WR(p_rx->set_prod_addr, *((u32 *)&rx_prod)); } -- 2.19.1