From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A160C43381 for ; Mon, 25 Feb 2019 21:13:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1753820C01 for ; Mon, 25 Feb 2019 21:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129235; bh=abV2CKxaW9zITR5aTp6ggOXIpeEVtZ/+KNtPxyOghtU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mr127GqfwNEMlPeUQTe/boE7LcBTI4zPISB0bikEdud/dxAw3eTqUBhH1uh6yDaJg FsM5ni+miJMTaxPB64eg0kPUU/1dC5/JNG4tsV21/SelOGZ8ZL6qhsf1EhZZ9XxB9P +GWBC9dBramyXaDefru9l96WXCbw3k4//n1CvjzU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729085AbfBYVNx (ORCPT ); Mon, 25 Feb 2019 16:13:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:44570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729055AbfBYVNv (ORCPT ); Mon, 25 Feb 2019 16:13:51 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C419320C01; Mon, 25 Feb 2019 21:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129230; bh=abV2CKxaW9zITR5aTp6ggOXIpeEVtZ/+KNtPxyOghtU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JQdp/K9cDL4kDnPRt7WTMgW5ImUZiTdmef+hGfWgbl95Hq8mIAnGNhJrDBxvclLCj ssocAQ4HEKxAMNZidEuxroifNPEEZJbUBhB0u7BqfwafbcuWBm7+njnma8FABEYrDK LGeeKwBM2NhrOnMhFGnJmtMnxHrlo5HVz70049kU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Linus Walleij , Lee Jones , Sasha Levin Subject: [PATCH 4.9 11/63] mfd: ab8500-core: Return zero in get_register_interruptible() Date: Mon, 25 Feb 2019 22:11:11 +0100 Message-Id: <20190225195036.586334418@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195035.713274200@linuxfoundation.org> References: <20190225195035.713274200@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 10628e3ecf544fa2e4e24f8e112d95c37884dc98 ] This function is supposed to return zero on success or negative error codes on error. Unfortunately, there is a bug so it sometimes returns non-zero, positive numbers on success. I noticed this bug during review and I can't test it. It does appear that the return is sometimes propogated back to _regmap_read() where all non-zero returns are treated as failure so this may affect run time. Fixes: 47c1697508f2 ("mfd: Align ab8500 with the abx500 interface") Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/ab8500-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c index 589eebfc13df9..2f212bdc187a4 100644 --- a/drivers/mfd/ab8500-core.c +++ b/drivers/mfd/ab8500-core.c @@ -257,7 +257,7 @@ static int get_register_interruptible(struct ab8500 *ab8500, u8 bank, mutex_unlock(&ab8500->lock); dev_vdbg(ab8500->dev, "rd: addr %#x => data %#x\n", addr, ret); - return ret; + return (ret < 0) ? ret : 0; } static int ab8500_get_register(struct device *dev, u8 bank, -- 2.19.1