From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8495FC43381 for ; Mon, 25 Feb 2019 21:17:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 524452173C for ; Mon, 25 Feb 2019 21:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129436; bh=dpPpz7fy43gUxDTrMpHSZsaZTIQ24W7hjsoH8woaiTA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BDky0GYPhOVPRNyZYlZnerzDZzYDgryb6MvfF/W3mQ+bjyL1cgyDik0afnu3JlPZj MWXqmLeyj3b+XqHUhQoJyvyNaRX5dRBf9YgQYFXZ5gjfkd13aR8Ws84jHdV84hhpwN v5q/mK/RWkUgj1ToOMcd8ngc+PICNuOajRBvESvE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729879AbfBYVRO (ORCPT ); Mon, 25 Feb 2019 16:17:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:49214 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727695AbfBYVRK (ORCPT ); Mon, 25 Feb 2019 16:17:10 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89DB12173C; Mon, 25 Feb 2019 21:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129430; bh=dpPpz7fy43gUxDTrMpHSZsaZTIQ24W7hjsoH8woaiTA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=13kWjzPKuDaeMVu4bxG7MKCZV5NwWj3L2zpOvOpU7bpkd35GfiDjp5jkoOrjZBVh6 gXkrmQAxdJ2TEyOZTu85dGEJaPqk9CANXQ8yPHOQn2LdHvC733Gvh9SmBaGyj21Yel fixwUmrdDpHxuI1JUeIw4D+49HhJv6F0E8voUt+g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Manish Rangankar , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 28/71] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param Date: Mon, 25 Feb 2019 22:11:30 +0100 Message-Id: <20190225195036.630289368@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195034.555044862@linuxfoundation.org> References: <20190225195034.555044862@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 72b4a0465f995175a2e22cf4a636bf781f1f28a7 ] The return code should be check while qla4xxx_copy_from_fwddb_param fails. Signed-off-by: YueHaibing Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index a6aa08d9a171c..22dc70a2138e2 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -7241,6 +7241,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct scsi_qla_host *ha, rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn, fw_ddb_entry); + if (rc) + goto free_sess; ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n", __func__, fnode_sess->dev.kobj.name); -- 2.19.1