From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995F7C43381 for ; Mon, 25 Feb 2019 21:19:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6832621841 for ; Mon, 25 Feb 2019 21:19:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129578; bh=02287DhGCpnhjjhGmYkLUO2T2CNbC9lALpykDV9omqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bnfFsGy6SSTUbdqTj5ZRjLdI507AjcSXHry/k+ZICTwx8MKjZ4XvASbaezNd2YzdS P4VuDJSsDIMeqGpEqlvfrkYbW3J32ULxpVHYUQ2EahgWgWPHvCdUFRTVHpvalL4afJ xF+Az5tWuHIFOTxpEUrkH/oogD8TZ3h6pShfjVT4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730334AbfBYVTg (ORCPT ); Mon, 25 Feb 2019 16:19:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:52670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729700AbfBYVTe (ORCPT ); Mon, 25 Feb 2019 16:19:34 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2978D21841; Mon, 25 Feb 2019 21:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129573; bh=02287DhGCpnhjjhGmYkLUO2T2CNbC9lALpykDV9omqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zODOfLMhaMime1U90wbTexZGJAxm74Wxb+3qzLPkgYqDQlhKwALvrRwnj05bSPA/n CgL2C9vQ0B+RwmB2x+TyRBzlbpwZ9MfTs+zyCfoUU9mjbe0uY6LjmnCZ9fdxqOYmUQ 9EU4OO3P8iKt8/Y5Oteu7gKL/xtQzxsSS8qiJusM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , Jacek Anaszewski , Sasha Levin Subject: [PATCH 4.14 40/71] leds: lp5523: fix a missing check of return value of lp55xx_read Date: Mon, 25 Feb 2019 22:11:42 +0100 Message-Id: <20190225195037.587901608@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195034.555044862@linuxfoundation.org> References: <20190225195034.555044862@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 248b57015f35c94d4eae2fdd8c6febf5cd703900 ] When lp55xx_read() fails, "status" is an uninitialized variable and thus may contain random value; using it leads to undefined behaviors. The fix inserts a check for the return value of lp55xx_read: if it fails, returns with its error code. Signed-off-by: Kangjie Lu Signed-off-by: Jacek Anaszewski Signed-off-by: Sasha Levin --- drivers/leds/leds-lp5523.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 924e50aefb003..13838d72e2971 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -318,7 +318,9 @@ static int lp5523_init_program_engine(struct lp55xx_chip *chip) /* Let the programs run for couple of ms and check the engine status */ usleep_range(3000, 6000); - lp55xx_read(chip, LP5523_REG_STATUS, &status); + ret = lp55xx_read(chip, LP5523_REG_STATUS, &status); + if (ret) + return ret; status &= LP5523_ENG_STATUS_MASK; if (status != LP5523_ENG_STATUS_MASK) { -- 2.19.1