From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50EFCC43381 for ; Mon, 25 Feb 2019 21:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16EDD21841 for ; Mon, 25 Feb 2019 21:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129856; bh=6zjfUI5vPQ6Hq6mWsFu8jxpMXx14jh9CRvfHsjX5i28=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=SM/RXuAR1FAifkkfqz1nesvwOUNt3kS0yYp2RCFIX94cL2rTSyp7ExtJmXhQuODGP HVx2Rk3R2yQRqAc/+xSiraPTy6Pxkmr2Wkbj0/y1rBSRnATGPU32M9GKVqGod+1/e1 W4yO6O44SXCunkekdKtoZa4/SczJ+ZFvatsG1i8A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731227AbfBYVYP (ORCPT ); Mon, 25 Feb 2019 16:24:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:58678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731207AbfBYVYK (ORCPT ); Mon, 25 Feb 2019 16:24:10 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BAB9217F5; Mon, 25 Feb 2019 21:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129850; bh=6zjfUI5vPQ6Hq6mWsFu8jxpMXx14jh9CRvfHsjX5i28=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tHAKrWYm8VEFsclKqFm1Bn1JfIx+U7iarnJUnd5AiNekwFsk7xgovvd/mXkb2zogg itDAKanwhvEN9EMfLee2dYvXeoNArDW265eIbDDNkQEOHRS2jsTSLdTgDjEruSXEOy d41zl6ikv1pr7Z/q5NAqatwsOA8fLDM0PH8zLNeI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 087/152] atm: he: fix sign-extension overflow on large shift Date: Mon, 25 Feb 2019 22:11:19 +0100 Message-Id: <20190225195049.021382792@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195043.645958524@linuxfoundation.org> References: <20190225195043.645958524@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit cb12d72b27a6f41325ae23a11033cf5fedfa1b97 ] Shifting the 1 by exp by an int can lead to sign-extension overlow when exp is 31 since 1 is an signed int and sign-extending this result to an unsigned long long will set the upper 32 bits. Fix this by shifting an unsigned long. Detected by cppcheck: (warning) Shifting signed 32-bit value by 31 bits is undefined behaviour Signed-off-by: Colin Ian King Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/he.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 29f102dcfec49..329ce9072ee9f 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c @@ -717,7 +717,7 @@ static int he_init_cs_block_rcm(struct he_dev *he_dev) instead of '/ 512', use '>> 9' to prevent a call to divdu3 on x86 platforms */ - rate_cps = (unsigned long long) (1 << exp) * (man + 512) >> 9; + rate_cps = (unsigned long long) (1UL << exp) * (man + 512) >> 9; if (rate_cps < 10) rate_cps = 10; /* 2.2.1 minimum payload rate is 10 cps */ -- 2.19.1