From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE9CC43381 for ; Mon, 25 Feb 2019 21:30:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C6C7217F5 for ; Mon, 25 Feb 2019 21:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551130247; bh=S5zZBF4upskm7DCZTllBaEL3um8L3vdjdBS9cCT0nww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NkLzw0LZDe8YD0DTuNCqp6/NXfmsDVg+CZncfkacZ02MZWDcGdJjm8JXXpKPelAVR 7QsgeyWxzzrtwbwzKkNPNDAVWqvdyWiGIF6+Klydhm+x4VJ+VMBctm+iwtEyctQ4D5 9Ps0gxAQGFFeZlmasNxLncnEud8MvJre1JubQv8Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732196AbfBYVaq (ORCPT ); Mon, 25 Feb 2019 16:30:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:36338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729531AbfBYVan (ORCPT ); Mon, 25 Feb 2019 16:30:43 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CACE7217F5; Mon, 25 Feb 2019 21:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551130243; bh=S5zZBF4upskm7DCZTllBaEL3um8L3vdjdBS9cCT0nww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oS1fbTLE3UcOraGnZLYtEqzUtHDaxkl4k/RPSL3ZLPF527pXrLDcaZvG2gELCc8JO ESiCAtTXGfZkHRSqgPJn9rftAyWBZOLu/QvCG6QnR8yW9VAsERoar1IC+L9dyds5bd UWqeho88yYnRO6Efpn+e3ypxb5ugjAUjlQ2ICtNw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Manish Rangankar , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.20 057/183] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param Date: Mon, 25 Feb 2019 22:10:30 +0100 Message-Id: <20190225195104.141940945@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195054.748060397@linuxfoundation.org> References: <20190225195054.748060397@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 72b4a0465f995175a2e22cf4a636bf781f1f28a7 ] The return code should be check while qla4xxx_copy_from_fwddb_param fails. Signed-off-by: YueHaibing Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 051164f755a4c..a13396c56a6a1 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -7237,6 +7237,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct scsi_qla_host *ha, rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn, fw_ddb_entry); + if (rc) + goto free_sess; ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n", __func__, fnode_sess->dev.kobj.name); -- 2.19.1