The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tom Li <tomli@tomli.me>
To: Nicolas Pitre <nicolas.pitre@linaro.org>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>, Adam Borowski <kilobyte@angband.pl>,
	Mikulas Patocka <mpatocka@redhat.com>,
	Alexander Potapenko <glider@google.com>,
	Yifeng Li <tomli@tomli.me>, Mike Frysinger <vapier@chromium.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [RFC 1/1] tty: vt.c: Fix TIOCL_BLANKSCREEN VT console blanking if blankinterval == 0
Date: Tue, 26 Feb 2019 19:20:26 +0800	[thread overview]
Message-ID: <20190226112026.GA21300@localhost.localdomain> (raw)
In-Reply-To: <nycvar.YSQ.7.76.1902251314490.1971@knanqh.ubzr>

> Wouldn't this problem be fixed simply by the following:
> 
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 9646ff63e7..41b17c4b5a 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -4151,8 +4151,6 @@ void do_blank_screen(int entering_gfx)
>  		return;
>  	}
>  
> -	if (blank_state != blank_normal_wait)
> -		return;
>  	blank_state = blank_off;
>  
>  	/* don't blank graphics */
> 
> I just can't find a logical reason for that conditional return.
> 
> 
> Nicolas

I see. I was concerned about the possibly unwanted effect if the function
is reentered, but it seems that there's no logic reason to worry at all.

I'll send a new patch according to your suggestion.

Thanks,
Tom Li

      reply	other threads:[~2019-02-26 11:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 16:43 [RFC 0/1] Fix TIOCL_BLANKSCREEN VT console blanking if blankinterval == 0 Yifeng Li
2019-02-25 16:43 ` [RFC 1/1] tty: vt.c: " Yifeng Li
2019-02-25 18:29   ` Nicolas Pitre
2019-02-26 11:20     ` Tom Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226112026.GA21300@localhost.localdomain \
    --to=tomli@tomli.me \
    --cc=daniel.vetter@ffwll.ch \
    --cc=glider@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kilobyte@angband.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=nicolas.pitre@linaro.org \
    --cc=vapier@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox