From: Borislav Petkov <bp@alien8.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] EDAC/amd64: Support more than two Controllers for Chip Select handling
Date: Tue, 26 Feb 2019 14:24:16 +0100 [thread overview]
Message-ID: <20190226132416.GE14836@zn.tnic> (raw)
In-Reply-To: <20190219202536.15462-4-Yazen.Ghannam@amd.com>
On Tue, Feb 19, 2019 at 08:26:09PM +0000, Ghannam, Yazen wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
>
> The struct chip_select array that's used for saving Chip Select bases
> and masks is fixed at length of two. There should be one struct
> chip_select for each controller, so this array should be increased to
> support systems that may have more than two controllers.
>
> Increase the size of the struct chip_select array to eight, which is the
> largest number of controllers per die currently supported on AMD
> systems.
>
> Also, carve out the Fam17h+ reading of the bases/masks into a separate
> function. This effectively reverts the original bases/masks reading code
> to pre-Fam17h support.
I like it simpler again. :-)
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-02-26 13:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 20:25 [PATCH 1/5] EDAC/amd64: Add Fam17hMod30h PCI IDs Ghannam, Yazen
2019-02-19 20:25 ` [PATCH 2/5] EDAC/amd64: Support more than two UMCs Ghannam, Yazen
2019-02-26 11:07 ` Borislav Petkov
2019-02-26 15:12 ` Ghannam, Yazen
2019-02-19 20:25 ` [PATCH 3/5] EDAC/amd64: Recognize x16 Symbol Size Ghannam, Yazen
2019-02-26 13:17 ` Borislav Petkov
2019-02-19 20:26 ` [PATCH 4/5] EDAC/amd64: Support more than two Controllers for Chip Select handling Ghannam, Yazen
2019-02-26 13:24 ` Borislav Petkov [this message]
2019-02-19 20:26 ` [PATCH 5/5] EDAC/amd64: Adjust printed Chip Select sizes when interleaved Ghannam, Yazen
2019-02-26 10:41 ` [PATCH 1/5] EDAC/amd64: Add Fam17hMod30h PCI IDs Borislav Petkov
2019-02-26 15:07 ` Ghannam, Yazen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226132416.GE14836@zn.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox