From: Andrew Lunn <andrew@lunn.ch>
To: Rajasingh Thavamani <T.Rajasingh@landisgyr.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: Micrel KSZ8061: link failure after cable connect
Date: Tue, 26 Feb 2019 15:06:08 +0100 [thread overview]
Message-ID: <20190226140608.GF3809@lunn.ch> (raw)
In-Reply-To: <20190226081506.25887-1-T.Rajasingh@landisgyr.com>
On Tue, Feb 26, 2019 at 01:45:06PM +0530, Rajasingh Thavamani wrote:
> With Micrel KSZ8061 PHY, the link may occasionally not come up after
> Ethernet cable connect. The vendor's (Microchip, former Micrel) errata
> sheet 80000688A.pdf descripes the problem and possible workarounds in
> detail, see below.
> The batch implements workaround 1, which permanently fixes the issue.
...
> PLAN
> This errata will not be corrected in the future revision.
>
> Signed-off-by: Rajasingh Thavamani <T.Rajasingh@landisgyr.com>
We have been here before:
https://lkml.org/lkml/2018/11/23/466
At that time, the patch was from Alexander Onnasch, and has his
signed-off-by. Now it only has your SOB. It probably should have
both. My reviewed-by has gone missing. And this is version 3? And in
the comments i also included a Fixed: tag, which should be added.
Please submit a v4 with all these issues fixed.
Thanks
Andrew
prev parent reply other threads:[~2019-02-26 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 8:15 [PATCH] net: phy: Micrel KSZ8061: link failure after cable connect Rajasingh Thavamani
2019-02-26 14:06 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226140608.GF3809@lunn.ch \
--to=andrew@lunn.ch \
--cc=T.Rajasingh@landisgyr.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox