public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Morris Ku <saumah@gmail.com>
Cc: morris_ku@sunix.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Add support SUNIX Multi-I/O board
Date: Wed, 27 Feb 2019 09:17:23 +0100	[thread overview]
Message-ID: <20190227081723.GA20777@kroah.com> (raw)
In-Reply-To: <20190227071702.4103-1-saumah@gmail.com>

On Wed, Feb 27, 2019 at 03:17:02PM +0800, Morris Ku wrote:
> Add Kconfig and Makefile entry.
> 
> ---
>  Kconfig  | 2 ++
>  Makefile | 1 +
>  2 files changed, 3 insertions(+)

<snip>

Oh, this series has lots of issues, not the least being this single
patch breaks the build :(

Every patch needs to build properly, or at the least, not stop
everything else from building.

I recommend reading Documentation/SubmittingPatches for how to do a
patch submission properly, and if you have specific questions after
reading that, I will be glad to answer them.

Also, please use scripts/checkpatch.pl on your patches, it will point
out lots of issues that I'll be nice and not mention at the moment :)

thanks,

greg k-h

      reply	other threads:[~2019-02-27  8:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27  7:17 [PATCH 1/5] Add support SUNIX Multi-I/O board Morris Ku
2019-02-27  8:17 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190227081723.GA20777@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=morris_ku@sunix.com \
    --cc=saumah@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox