From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 1/3] perf diff: Support --time filter option
Date: Wed, 27 Feb 2019 10:27:55 +0100 [thread overview]
Message-ID: <20190227092755.GA22793@krava> (raw)
In-Reply-To: <1551183069-5931-2-git-send-email-yao.jin@linux.intel.com>
On Tue, Feb 26, 2019 at 08:11:07PM +0800, Jin Yao wrote:
SNIP
> + abstime_tmp = abstime_ostr;
>
> data__for_each_file(i, d) {
> - d->session = perf_session__new(&d->data, false, &tool);
> + d->session = perf_session__new(&d->data, false, &pdiff.tool);
> if (!d->session) {
> pr_err("Failed to open %s\n", d->data.path);
> ret = -1;
> goto out_delete;
> }
>
> + if (abstime_ostr) {
> + ret = parse_absolute_time(d, &abstime_tmp);
> + if (ret < 0)
> + goto out_delete;
> + } else if (pdiff.time_str) {
> + ret = parse_percent_time(d);
> + if (ret < 0)
> + goto out_delete;
> + } else {
> + pdiff.range_num = 1;
hum, why are we setting range_num to 1 again?
it's really hard to parse this code, maybe
it'd be better in separate loop/function
that would setup just timestamps..
thanks,
jirka
next prev parent reply other threads:[~2019-02-27 9:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 12:11 [PATCH v2 0/3] perf diff: Add new filter options Jin Yao
2019-02-26 12:11 ` [PATCH v2 1/3] perf diff: Support --time filter option Jin Yao
2019-02-27 9:27 ` Jiri Olsa [this message]
2019-02-27 13:04 ` Jin, Yao
2019-02-27 13:25 ` Jiri Olsa
2019-02-27 9:28 ` Jiri Olsa
2019-02-27 12:51 ` Jin, Yao
2019-02-27 13:10 ` Jiri Olsa
2019-02-27 14:24 ` Jin, Yao
2019-02-26 12:11 ` [PATCH v2 2/3] perf diff: Support --cpu " Jin Yao
2019-02-26 12:11 ` [PATCH v2 3/3] perf diff: Support --pid/--tid filter options Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227092755.GA22793@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox