From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C0BCC43381 for ; Wed, 27 Feb 2019 14:33:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF7B0217F9 for ; Wed, 27 Feb 2019 14:33:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Svm6JGhE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730721AbfB0Odd (ORCPT ); Wed, 27 Feb 2019 09:33:33 -0500 Received: from merlin.infradead.org ([205.233.59.134]:34844 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730222AbfB0Odb (ORCPT ); Wed, 27 Feb 2019 09:33:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NVuWjNFQqO8k6nWme88iEs0j/STshI5Yj7elnIJPY5M=; b=Svm6JGhEbCAL68rpI6zoZb8Zf OZCa4kjQ056m3QvyXCWxf8S5QEz9WXp+DkD2S5LzUfCq/CLHAIDKg+dAWeYy6N5rbeEro+LiSARY7 JLM18+/LMhhIvyM3jR4rpc8rkwF2dtJxWS7S/MosZUfXXvBXiVKD8A4EHqRHXi7FgTSR759aH1Qkx Ak9PLioMIEkyXjuncA+vFX6WC5XkJKVdYyJ9+iKlnd2g1w2Ggww6grKVRJqxVZwC2NUof2DRX+xuy 2d1Zxq348u86GpCgcFCn6QUOPUg952C9hw+I/hKjgdiA0BwB53AHN6lg5EhrQ/nd3CNDG3w9/pF1n y0PfQYEow==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gz0Gp-0003Y7-Pa; Wed, 27 Feb 2019 14:33:16 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 6140A2851B829; Wed, 27 Feb 2019 15:33:13 +0100 (CET) Date: Wed, 27 Feb 2019 15:33:13 +0100 From: Peter Zijlstra To: Andrey Ryabinin Cc: torvalds@linux-foundation.org, tglx@linutronix.de, hpa@zytor.com, julien.thierry@arm.com, will.deacon@arm.com, luto@amacapital.net, mingo@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, valentin.schneider@arm.com, brgerst@gmail.com, jpoimboe@redhat.com, luto@kernel.org, bp@alien8.de, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, glider@google.com, dvyukov@google.com Subject: Re: [PATCH 5/6] objtool: Add UACCESS validation Message-ID: <20190227143313.GK32534@hirez.programming.kicks-ass.net> References: <20190225124330.613028745@infradead.org> <20190225125232.191698923@infradead.org> <20190227140830.GP32494@hirez.programming.kicks-ass.net> <19b35cb1-9527-2e15-6deb-9ce7c1ef1d66@virtuozzo.com> <20190227142623.GR32494@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190227142623.GR32494@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 27, 2019 at 03:26:23PM +0100, Peter Zijlstra wrote: > On Wed, Feb 27, 2019 at 05:17:58PM +0300, Andrey Ryabinin wrote: > > > > > > On 2/27/19 5:08 PM, Peter Zijlstra wrote: > > > > I can't actually find any definitions of those functions, so I can't > > > very well mark the safe, even if we wanted to. > > > > > > > They are macro-generated. Use 'git grep DEFINE_ASAN' > > Ah, indeed! I'll go have a look. Urgh, kasan_report() is definitely unsafe. Now, admitedly we should 'never' hit that, but it does leave us up a creek without a paddle. Not sure what to do here; best I can come up with atm. is kill SMAP on KASAN builds.