Re: [PATCH v4 3/5] arm64: dts: imx8mq: Add SAI2 node

Daniel Baluta
2019-03-01T12:26:08Z

On Thu, Feb 28, 2019 at 8:49 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Wed, Feb 27, 2019 at 3:38 AM Daniel Baluta <daniel.baluta@nxp.com> wrote:
>
> > + sai2: sai@308b0000 {
> > + #sound-dai-cells = <0>;
> > + compatible = "fsl,imx8mq-sai",
> > + "fsl,imx6sx-sai";
> > + reg = <0x308b0000 0x10000>;
> > + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MQ_CLK_SAI2_IPG>,
> > + <&clk IMX8MQ_CLK_DUMMY>,
> > + <&clk IMX8MQ_CLK_SAI2_ROOT>,
> > + <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>;
> > + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
>
> mclk0 is not a valid entry as per the binding doc.

Indeed, will fix in next version. mclk0 is valid in our internal tree
because fsl_sai.c supports it.
Will remove mclk0 for now and re-add it when I will upstream the SAI patch.

Thanks Fabio for review!