public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Eugeniy Paltsev <eugeniy.paltsev@synopsys.com>
Cc: Vineet Gupta <vgupta@synopsys.com>,
	linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARCv2: Add explcit unaligned access support (and ability to disable too)
Date: Thu, 28 Feb 2019 09:47:42 -0800	[thread overview]
Message-ID: <20190228174742.GA18868@roeck-us.net> (raw)

On Wed, Jan 30, 2019 at 07:32:41PM +0300, Eugeniy Paltsev wrote:
> As of today we enable unaligned access unconditionally on ARCv2.
> Do this under a Kconfig option to allow disable it for test, benchmarking
> etc. Also while at it
> 
>   - Select HAVE_EFFICIENT_UNALIGNED_ACCESS
>   - Although gcc defaults to unaligned access (since GNU 2018.03), add the
>     right toggles for enabling or disabling as appropriate
>   - update bootlog to prints both HW feature status (exists, enabled/disabled)
>     and SW status (used / not used).
>   - wire up the relaxed memcpy for unaligned access
> 
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> [vgupta: squashed patches, handle gcc -mno-unaligned-access quick]

Hi,

with my brand-new gcc-8.3.0, built from upstream gcc, this patch
results in

arch/arc/kernel/setup.c: In function 'arc_cpu_mumbojumbo.constprop':
include/linux/compiler.h:348:38: error:
	call to '__compiletime_assert_326' declared with attribute error: gcc doesn't support -mno-unaligned-access

when trying to build allnoconfig or tinyconfig. I get the same results
with gcc-8.2.0.

Do I need some special compiler configuration flag when building the
arcv2 toolchain ? Or am I simply out of luck for using upstream gcc ?

Thanks,
Guenter

             reply	other threads:[~2019-02-28 17:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 17:47 Guenter Roeck [this message]
2019-02-28 18:12 ` [PATCH] ARCv2: Add explcit unaligned access support (and ability to disable too) Vineet Gupta
2019-02-28 18:59   ` Guenter Roeck
2019-02-28 19:24     ` Vineet Gupta
2019-03-04 22:32       ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190228174742.GA18868@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=eugeniy.paltsev@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=vgupta@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox