Re: [PATCH 1/3] list_bl: Add hlist_bl_add_before/behind helpers

Christoph Hellwig
2019-03-11T18:16:12Z

On Thu, Feb 28, 2019 at 04:32:02PM -0500, Mike Snitzer wrote:
> Hi Paul and Christoph,
>
> You've added your Signed-off-by to include/linux/list_bl.h commits in
> the past. I'm not sure how this proposed patch should be handled.
>
> These new hlist_bl_add_{before,behind} changes are a prereq for
> dm-snapshot changes that Nikos has proposed, please see:
> https://patchwork.kernel.org/patch/10739265/
>
> Any assistance/review you, or others on LKML, might be able to provide
> would be appreciated.

I just killed two helpers. That being said assuming that we only
rely on the next pointer for the lockless traversals the changes look
fine to me, but the code might be beyond my paygrade..