From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Cc: lee.jones@linaro.org, bleung@chromium.org,
enric.balletbo@collabora.com, groeck@chromium.org,
linux-kernel@vger.kernel.org, gwendal@google.com,
jettrink@chromium.org
Subject: Re: [PATCH v2] mfd: cros_ec: instantiate properly CrOS ISH MCU device
Date: Fri, 1 Mar 2019 09:28:11 +0200 [thread overview]
Message-ID: <20190301072811.GH9224@smile.fi.intel.com> (raw)
In-Reply-To: <1551413171-27290-1-git-send-email-rushikesh.s.kadam@intel.com>
On Fri, Mar 01, 2019 at 09:36:11AM +0530, Rushikesh S Kadam wrote:
> Integrated Sensor Hub (ISH) is also a MCU running EC
> having feature bit EC_FEATURE_ISH. Instantiate it as
> a special CrOS EC device with device name 'cros_ish'.
> v2
> - Addressed review comments to term the CrOS EC device as a generic
> Integrated Sensor Hub.
> + /* The MCU is an Intel Integrated Sensor Hub */
This has to be adjusted as well. Intel ISH is just one of the example of ISHs.
> + EC_FEATURE_ISH = 40,
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-03-01 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 4:06 [PATCH v2] mfd: cros_ec: instantiate properly CrOS ISH MCU device Rushikesh S Kadam
2019-03-01 7:28 ` Andy Shevchenko [this message]
2019-03-01 8:42 ` Rushikesh S Kadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301072811.GH9224@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@google.com \
--cc=jettrink@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rushikesh.s.kadam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox