From: Andrew Lunn <andrew@lunn.ch>
To: Antoine Tenart <antoine.tenart@bootlin.com>
Cc: davem@davemloft.net, linux@armlinux.org.uk, f.fainelli@gmail.com,
hkallweit1@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
maxime.chevallier@bootlin.com, gregory.clement@bootlin.com,
miquel.raynal@bootlin.com, nadavh@marvell.com,
stefanc@marvell.com, mw@semihalf.com
Subject: Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default
Date: Fri, 1 Mar 2019 15:19:53 +0100 [thread overview]
Message-ID: <20190301141953.GF19813@lunn.ch> (raw)
In-Reply-To: <20190301110047.20257-4-antoine.tenart@bootlin.com>
On Fri, Mar 01, 2019 at 12:00:47PM +0100, Antoine Tenart wrote:
> When the Marvell 10G PHYs are set out of reset, the LPOWER bit is set
> depending on an hardware configuration choice. We also do not know what
> is the PHY state at boot time. Hence, set the PHY in low power by
> default when this driver probes.
Hi Antoine
Florian did some work for c22 PHYs so that the existing link state
could be used at boot. So for example, the bootloader configured the
PHY up and it got link, there is no need to down/up the PHY when linux
takes control. The networking comes up faster that way.
Can this work for this PHY?
Andrew
next prev parent reply other threads:[~2019-03-01 14:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 11:00 [PATCH net-next v2 0/3] net: phy: marvell10g: implement suspend/resume callbacks Antoine Tenart
2019-03-01 11:00 ` [PATCH net-next v2 1/3] " Antoine Tenart
2019-03-01 14:16 ` Andrew Lunn
2019-03-01 11:00 ` [PATCH net-next v2 2/3] net: phy: marvell10g: add the suspend/resume callbacks for the 88x2210 Antoine Tenart
2019-03-01 14:15 ` Andrew Lunn
2019-03-01 11:00 ` [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default Antoine Tenart
2019-03-01 14:19 ` Andrew Lunn [this message]
2019-03-01 15:07 ` Antoine Tenart
2019-03-02 3:08 ` Florian Fainelli
2019-03-04 10:47 ` Antoine Tenart
2019-03-04 16:10 ` Russell King - ARM Linux admin
2019-03-05 12:54 ` Antoine Tenart
2019-03-04 18:46 ` [PATCH net-next v2 0/3] net: phy: marvell10g: implement suspend/resume callbacks David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301141953.GF19813@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox