Re: [PATCH v3 bus+gpio 3/5] bus: moxtet: Add sysfs documentation

Marek Behun
2019-03-01T15:15:14Z

On Fri, 1 Mar 2019 15:34:26 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> > +What: /sys/bus/moxtet/devices/moxtet-<name>.<addr>/output_value
> > +Date: March 2019
> > +KernelVersion: 5.2
> > +Contact: Marek Behún <marek.behun@nic.cz>
> > +Description: (RW) Read last written value or write value to the
> > module on
> > + this Moxtet address. Format: %x
>
> What is the usecase for these?
>
> If this is for debugging it should be in debugfs rather than in sysfs.
>
> If it is here for random userspace drivers, we need some good
> explanation as to why they can't just be kernel drivers.

Hmm, it was for debugging purposes but the ability to write there is
not needed anymore... Shall I make it read/only? Or completely remove
it?

Marek