From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vaishali Thakkar <vaishali.thakkar@linaro.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, rafael@kernel.org,
vkoul@kernel.org
Subject: Re: [PATCH v4 5/5] soc: qcom: socinfo: Expose image information
Date: Fri, 1 Mar 2019 11:51:40 -0800 [thread overview]
Message-ID: <20190301195140.GE27005@builder> (raw)
In-Reply-To: <20190225065044.11023-6-vaishali.thakkar@linaro.org>
On Sun 24 Feb 22:50 PST 2019, Vaishali Thakkar wrote:
> +#define IMAGE_SHOW_OEM(attr) \
> +static int show_ ##attr## _oem(struct seq_file *seq, void *p) \
> +{ \
> + struct smem_image_version *image_version = seq->private; \
> + seq_puts(seq, image_version->oem); \
> + seq_puts(seq, "\n"); \
> + return 0; \
> +} \
> +static int open_ ##attr## _oem(struct inode *inode, struct file *file) \
> +{ \
> + return single_open(file, show_ ##attr## _oem, inode->i_private); \
> +} \
> + \
> +static const struct file_operations qcom_ ##attr## _oem_ops = { \
> + .open = open_ ##attr## _oem, \
> + .read = seq_read, \
> + .llseek = seq_lseek, \
> + .release = single_release, \
> +}
> +
> +#define DEBUGFS_IMAGE_OEM(fname, attr, index) \
> +debugfs_create_file(__stringify(fname), 0400, qcom_socinfo->attr, \
> + &smem_image_version[index], &qcom_ ##attr## _oem_ops)
> +
> +#define IMAGE_SHOW(name) \
> + IMAGE_SHOW_NAME(name); \
> + IMAGE_SHOW_VARIANT(name); \
> + IMAGE_SHOW_OEM(name) \
> +
> +IMAGE_SHOW(boot);
Given that you pass &smem_image_version[index] as "data" it seems that
these instances will only differ in the function name. So you should be
able to have one set of these functions to handle all the images.
> +IMAGE_SHOW(tz);
> +IMAGE_SHOW(rpm);
> +IMAGE_SHOW(apps);
> +IMAGE_SHOW(mpss);
> +IMAGE_SHOW(adsp);
> +IMAGE_SHOW(cnss);
> +IMAGE_SHOW(video);
> +
Regards,
Bjorn
prev parent reply other threads:[~2019-03-01 19:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 6:50 [PATCH v4 0/5] soc: qcom: Add SoC info driver Vaishali Thakkar
2019-02-25 6:50 ` [PATCH v4 1/5] base: soc: Add serial_number attribute to soc Vaishali Thakkar
2019-02-28 19:23 ` Stephen Boyd
2019-02-25 6:50 ` [PATCH v4 2/5] base: soc: Export soc_device_register/unregister APIs Vaishali Thakkar
2019-02-28 19:23 ` Stephen Boyd
2019-03-01 19:08 ` Bjorn Andersson
2019-02-25 6:50 ` [PATCH v4 3/5] soc: qcom: Add socinfo driver Vaishali Thakkar
2019-02-28 19:34 ` Stephen Boyd
2019-03-01 19:23 ` Bjorn Andersson
2019-02-25 6:50 ` [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes Vaishali Thakkar
2019-02-28 21:32 ` Stephen Boyd
2019-03-14 11:25 ` Vaishali Thakkar
2019-03-14 15:58 ` Stephen Boyd
2019-03-21 5:51 ` Vaishali Thakkar
2019-03-23 0:01 ` Stephen Boyd
2019-03-24 17:42 ` Vaishali Thakkar
2019-03-25 16:01 ` Stephen Boyd
2019-03-25 20:58 ` Vaishali Thakkar
2019-03-01 19:42 ` Bjorn Andersson
2019-02-25 6:50 ` [PATCH v4 5/5] soc: qcom: socinfo: Expose image information Vaishali Thakkar
2019-02-28 21:34 ` Stephen Boyd
2019-03-01 19:51 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301195140.GE27005@builder \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vaishali.thakkar@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox