From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: Steve Muckle <smuckle@google.com>, Shuah Khan <shuah@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH] selftests: x86: add version check in test_syscall_vdso
Date: Sat, 2 Mar 2019 10:10:47 +0100 [thread overview]
Message-ID: <20190302091047.GA14963@kroah.com> (raw)
In-Reply-To: <CALCETrUcH9R62gDdiG-EGTfSt2kQktv-0+bYmPcLn4PWNMrHSQ@mail.gmail.com>
On Fri, Mar 01, 2019 at 11:59:24AM -0800, Andy Lutomirski wrote:
> > On Feb 28, 2019, at 4:18 PM, Steve Muckle <smuckle@google.com> wrote:
> >
> > Since 4.17 registers r8-r11 are not clobbered/zeroed by a 64-bit kernel
> > handling a 32-bit syscall and this behavior is enforced by the
> > test_syscall_vdso testcase. See commit 8bb2610bc496
> > ("x86/entry/64/compat: Preserve r8-r11 in int $0x80").
> >
> > Permit the old behavior in the testcase for kernels prior to 4.17.
>
> NAK. If you want an old buggy kernel to pass a test, please either
> patch the kernel or run an old test.
Yeah, this isn't ok, especially as you might have 4.14 or 4.9 kernels
that can pass the test if the needed patches were backported. Checking
kernel version numbers should never be used for anything.
greg k-h
next prev parent reply other threads:[~2019-03-02 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 0:18 [PATCH] selftests: x86: add version check in test_syscall_vdso Steve Muckle
2019-03-01 19:59 ` Andy Lutomirski
2019-03-02 9:10 ` Greg KH [this message]
2019-03-02 18:31 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190302091047.GA14963@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=smuckle@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox