From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: bp@alien8.de, natechancellor@gmail.com, niravd@google.com,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/boot: clean up headers
Date: Sat, 2 Mar 2019 13:30:10 +1100 [thread overview]
Message-ID: <20190302133010.135cd3ad@canb.auug.org.au> (raw)
In-Reply-To: <20190302132750.0916adc4@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
Hi Nick,
On Sat, 2 Mar 2019 13:27:50 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 1 Mar 2019 16:07:14 -0800 Nick Desaulniers <ndesaulniers@google.com> wrote:
> >
> > It turns out that arch/x86/boot/string.c doesn't actually need
> > linux/kernel.h, simply linux/limits.h and linux/compiler.h. Include them,
> > and sort the headers alphabetically.
>
> One small nit: please do not do the sort in the same commit as the bug
> fix. It just complicates the review and has (a remote) possibility of
> adding a new problem. (Not a big issue here, but in general cleanups
> and bug fixes should be separate.)
Also it is *very* common for headers to be included in the order:
linux/ asm/ and then local.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-02 2:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 0:07 [PATCH] x86/boot: clean up headers Nick Desaulniers
2019-03-02 0:13 ` Nathan Chancellor
2019-03-02 2:27 ` Stephen Rothwell
2019-03-02 2:30 ` Stephen Rothwell [this message]
2019-03-04 17:50 ` [PATCH v2] " Nick Desaulniers
2019-03-04 22:51 ` Stephen Rothwell
2019-03-05 0:12 ` [PATCH v3] " Nick Desaulniers
2019-03-05 0:15 ` Nick Desaulniers
2019-03-05 8:57 ` Borislav Petkov
2019-03-14 22:14 ` [PATCH v4] " Nick Desaulniers
2019-03-21 11:28 ` [tip:x86/urgent] x86/boot: Restrict header scope to make Clang happy tip-bot for Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190302133010.135cd3ad@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=niravd@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox