* A quesiton about commit 3a63f70bf4c3
@ 2019-03-01 6:06 Baoquan He
2019-03-04 1:27 ` Chao Fan
0 siblings, 1 reply; 3+ messages in thread
From: Baoquan He @ 2019-03-01 6:06 UTC (permalink / raw)
To: fanc.fnst; +Cc: bp, linux-kernel
Hi Chao,
I am back porting this commit to our distrols from tip.
3a63f70bf4c3 x86/boot: Early parse RSDP and save it in boot_params
Findind out those SRAT handling related declarations are out of
BOOT_COMPRESSED_MISC_H ifdeffery. Is this made on purpose?
Saw "misc.h" is included in several places, shouldn't be changed like
below? Please correct me if I was wrong.
Thanks
Baoquan
diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h
index fd13655..252091b 100644
--- a/arch/x86/boot/compressed/misc.h
+++ b/arch/x86/boot/compressed/misc.h
@@ -120,8 +120,6 @@ static inline void console_init(void)
void set_sev_encryption_mask(void);
-#endif
-
/* acpi.c */
#ifdef CONFIG_ACPI
acpi_physical_address get_rsdp_addr(void);
@@ -135,3 +133,4 @@ int count_immovable_mem_regions(void);
#else
static inline int count_immovable_mem_regions(void) { return 0; }
#endif
+#endif
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: A quesiton about commit 3a63f70bf4c3
2019-03-01 6:06 A quesiton about commit 3a63f70bf4c3 Baoquan He
@ 2019-03-04 1:27 ` Chao Fan
2019-03-04 4:18 ` Baoquan He
0 siblings, 1 reply; 3+ messages in thread
From: Chao Fan @ 2019-03-04 1:27 UTC (permalink / raw)
To: Baoquan He; +Cc: bp, linux-kernel
On Fri, Mar 01, 2019 at 02:06:31PM +0800, Baoquan He wrote:
>
>Hi Chao,
Hi Baoquan,
Sorry for late reply, I was away from keyboard last Friday.
Your change looks good, I think you can format it as a real PATCH.
>
>I am back porting this commit to our distrols from tip.
Thanks for your effort.
Thanks,
Chao Fan
>3a63f70bf4c3 x86/boot: Early parse RSDP and save it in boot_params
>
>Findind out those SRAT handling related declarations are out of
>BOOT_COMPRESSED_MISC_H ifdeffery. Is this made on purpose?
>
>Saw "misc.h" is included in several places, shouldn't be changed like
>below? Please correct me if I was wrong.
>
>Thanks
>Baoquan
>
>diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h
>index fd13655..252091b 100644
>--- a/arch/x86/boot/compressed/misc.h
>+++ b/arch/x86/boot/compressed/misc.h
>@@ -120,8 +120,6 @@ static inline void console_init(void)
>
> void set_sev_encryption_mask(void);
>
>-#endif
>-
> /* acpi.c */
> #ifdef CONFIG_ACPI
> acpi_physical_address get_rsdp_addr(void);
>@@ -135,3 +133,4 @@ int count_immovable_mem_regions(void);
> #else
> static inline int count_immovable_mem_regions(void) { return 0; }
> #endif
>+#endif
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: A quesiton about commit 3a63f70bf4c3
2019-03-04 1:27 ` Chao Fan
@ 2019-03-04 4:18 ` Baoquan He
0 siblings, 0 replies; 3+ messages in thread
From: Baoquan He @ 2019-03-04 4:18 UTC (permalink / raw)
To: Chao Fan; +Cc: bp, linux-kernel
On 03/04/19 at 09:27am, Chao Fan wrote:
> On Fri, Mar 01, 2019 at 02:06:31PM +0800, Baoquan He wrote:
> >
> >Hi Chao,
> Hi Baoquan,
>
> Sorry for late reply, I was away from keyboard last Friday.
> Your change looks good, I think you can format it as a real PATCH.
Thx, sent.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-04 4:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-01 6:06 A quesiton about commit 3a63f70bf4c3 Baoquan He
2019-03-04 1:27 ` Chao Fan
2019-03-04 4:18 ` Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox